1835163 - Language detection not working for language pairs going through a pivot language

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Marco Castelluccio [:marco]]

If you visit a page in language X and your browser's locale is Y, and there's no direct translation model from X to Y, the translation button is not shown in the address bar.

E.g. I opened https://ca.wikipedia.org/wiki/Viquip%C3%A8dia_en_hongar%C3%A8s
2 in my Italian Firefox, and I see the following error in the browser console after enabling verbose logging:

Translations: Translating from "ca" to "it" is not supported.

In the list of language pairs, I have:

{ fromLang: 'ca', toLang: 'en', isBeta: true },
and
{ fromLang: 'en', toLang: 'it', isBeta: false },
so this should actually be working.

The problem is likely this line: https://searchfox.org/mozilla-central/rev/ca52886e3b6051ca87861567e0c7628915f68780/toolkit/components/translations/actors/TranslationsChild.sys.mjs#629.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1813775

:gregtatum, since you are the author of the regressor, bug 1813775, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Pascal Chevrel:pascalc]

Marking 114 as disabled as Firefox Translations is not activated yet on release.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835163 - Make mockLocales a shared test function; r?nordzilla!

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835163 - Look up pivot languages for language detection; r?nordzilla!

Depends on D179485

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70c6c06d39ca
Make mockLocales a shared test function; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/77da9f02a857
Look up pivot languages for language detection; r=nordzilla

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/70c6c06d39ca
https://hg.mozilla.org/mozilla-central/rev/77da9f02a857