1835224 - The firefox add-on suggestion is cut-off instead of using faded text

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: add-on suggestion compared to weather suggestion

Found in

• Fx 115.0a1

Affected versions

• Fx 115.0a1

Affected platforms

• Windows 10
• macOS
• Ubuntu 20

Preconditions
browser.urlbar.addons.featureGate set to true
browser.urlbar.suggest.addons set to true
browser.urlbar.quicksuggest.enabled set to true
browser.urlbar.suggest.quicksuggest.nonsponsored set to true
browser.urlbar.quicksuggest.dataCollection.enabled set to true
browser.urlbar.merino.enabled set to true
browser.urlbar.merino.providers set to amo
browser.urlbar.bestMatch.enabled set to true

Steps to reproduce

1. Launch Firefox.
2. Reduce the Firefox window width.
3. Trigger an add-on suggestion by using any keyword (e.g. typo, darker, video dl)

Expected result

• Add-on suggestion title, url and description are correctly displayed with text fading out if entire suggestions doesn't fit in the window.

Actual result

• Text is cut off.

Regression range

• Not a regression.

Additional notes

• I've attached a screenshot comparing it to a weather suggestion.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:cbaica, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1835224: Set overflowable to fade the component

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f89282afd432
Set overflowable to fade the component r=adw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f89282afd432

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx 116.0a1 and Fx 115.0b4 on Windows 10 and Ubuntu 20.04. The text is now faded when the suggestion doesn't match the width.