1835279 - Add support for ES modules in PromiseWorker

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, task, P3)

Description

[Mark Banner (:standard8)]

Bug 1834360 added support for ES modules to Chrome workers.

We should probably use automatic detection of the file extension (mjs vs js) to set the module type when creating the chrome worker.

Using mjs also allows our tools to detect the files as modules, so I think it is reasonable to use that as the detection switch.

It might also be worth checking that PromiseWorker.js can correctly be loaded into a chrome module. I don't know if the require method will still work with modules.

Comment 1

[Rob Wu [:robwu]]

With support for ESM imports, require support is not strictly required, at least not for new code.

There is a new consumer of PromiseWorker in bug 1831947 that uses require for the lack of anything better, but if modules were to be supported, that would have been preferable. (Hmm would dynamic imports work to reduce the migration effort down the road?)

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1835279 - Add support for ES modules in PromiseWorker. r?Gijs!

In order to use the same implementation between regular script and module script,
convert PromiseWorker.js into a template, which is processed by GeneratePromiseWorkerScript.py.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4429ec0ce7e1
Add support for ES modules in PromiseWorker. r=Gijs

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 4429ec0ce7e1 (Bug 1835279) for causing failures in browser_all_files_referenced.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=J_P7Jr0jTki33yr5_CgqiA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=4429ec0ce7e1dd74548ba74abc439b70b4429931

Log: https://treeherder.mozilla.org/logviewer?job_id=423706588&repo=autoland&lineNumber=4208

Backout: https://hg.mozilla.org/integration/autoland/rev/e456cc863b26a4eaaef19a92d04686c72b991cdd

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05eb5d19b4fb
Add support for ES modules in PromiseWorker. r=Gijs

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/05eb5d19b4fb