Closed Bug 1835299 Opened 1 year ago Closed 1 year ago

enable missing benchmark tests on Beta/Release branches on Linux and OSX

Categories

(Testing :: Raptor, task, P1)

Default
task

Tracking

(firefox114 fixed, firefox115 fixed)

RESOLVED FIXED
115 Branch
Tracking Status
firefox114 --- fixed
firefox115 --- fixed

People

(Reporter: kshampur, Assigned: kshampur)

References

Details

(Whiteboard: [fxp])

Attachments

(1 file)

In bug 1827415 it was inteded for all the failing benchmarks to be re enabled, however one configuration was accidentally missed (the default case)

Attachment #9336115 - Attachment description: WIP: Bug 1835299 enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest → Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest

It looks like failures are happening again in beta for linux/mac so I will delay landing this

See Also: → 1835550

in bug 1835550, comment 3, the failures seem to have stopped. I will go ahead with landing and uplifting this patch

Pushed by kshampur@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83f34deeebbf enable missing benchmark tests on Beta/Release branches on Linux and OSX. r=perftest-reviewers,taskgraph-reviewers,jmaher,sparky

Comment on attachment 9336115 [details]
Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest

Beta/Release Uplift Approval Request

  • User impact if declined: none
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): only affects perf tests, not user
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9336115 - Attachment description: Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest → WIP: Bug 1835299 enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest
Attachment #9336115 - Flags: approval-mozilla-beta?
Attachment #9336115 - Attachment description: WIP: Bug 1835299 enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest → Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest

Comment on attachment 9336115 [details]
Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest

Fx114 is now in RC, switching uplift request to release

Attachment #9336115 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

Comment on attachment 9336115 [details]
Bug 1835299 - enable missing benchmark tests on Beta/Release branches on Linux and OSX. r?#perftest

Approved for 114 RC 2, thanks.

Attachment #9336115 - Flags: approval-mozilla-release? → approval-mozilla-release+
See Also: → 1863175
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: