1835357 - dbtests.sh failure in "certutil dump keys with explicit default trust flags"

Status: RESOLVED FIXED

(NSS :: Test, defect, P3)

Description

[John Schanck [:jschanck]]

The DB tests are failing pretty consistently since Bug 1774657 landed. The logs show:
"dbtests.sh: #27: certutil dump keys with explicit default trust flags - FAILED"

The failing test ensures that some operation completes in under 2 seconds. I'm not sure if there's a performance regression or if 2 seconds is just not a reasonable upper bound.

Push with failures: https://treeherder.mozilla.org/jobs?repo=nss&revision=f7ae42e6be7e525fe91e01478a16734a8743e277
Log: https://firefoxci.taskcluster-artifacts.net/7WPEi4KdQnGxvG9QUTe7yQ/0/public/logs/live_backing.log

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rrelyea, since you are the author of the regressor, bug 1774657, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Robert Relyea]

Yes, it's probably a platform delay on a timing test.

Comment 3

[Robert Relyea]

Yeah, the timing value is too tight. The failure case is order of 10-20 seconds. I'll move the accepted value up to 5 (it's 1.99 right now and we're failing at about 2.5).

Comment 4

[Robert Relyea]

(Note: the failing test is a new test added by the patch, so it's not a performance regression caused by the patch causing the failure).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:beurdouche, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Robert Relyea]

Attachment: Bug 1835357 dbtests.sh failure in "certutil dump keys with explicit default trust flags" r=jschanck

Fix the time value so we don't fail on slower or overloaded platforms.

bob

Comment 7

[Robert Relyea]

argh. I made a patch. I tested the patch, and I forgot to submit it...

Comment 8

[Benjamin Beurdouche [:beurdouche]]

Hi Bob, can you set priority and severity for this please ? : ) Thanks !

Comment 9

[Robert Relyea]

Setting priority but also closing the bug. The patch has been checked in.