1835556 - Moving virtual folder within maildir based imap or local folder sometimes fails

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[gene smith]

This is pretty obscure bug (or bugs) that I noticed while testing the addition of context (right-click) selected move and copy of folders, bug 1831759.

Moving a virtual (search) folder within Local Folders that are maildir based, the move does not occur. See this error on console:

[Parent 1054589, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /home/gene/mozilla2/comm/mailnews/local/src/nsMsgMaildirStore.cpp:438
JavaScript error: chrome://messenger/content/about3Pane.js, line 2458: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgCopyService.copyFolder]

Move of virtual folder works OK on mbox based Local Folders.

When moving a virtual folder within an imap account/server, you can move it to any folder one time within a session. If you try to move it more than once back to the same folder, often the move does not occur. It also sometimes hits an "ENSURE_SUCCESS(rv, rv) here:
https://searchfox.org/comm-central/rev/a8a527d3a13553a492016f9dba13f09c758e1afc/mailnews/imap/src/nsImapMailFolder.cpp#7383
failing with NS_ERROR_FILE_ALREADY_EXISTS which will prevent the move. It works better with that line commented out, but doesn't really fix the problem.
Restarting tb clears the confusion and you can move the virtual folder anywhere within the same imap account again one time.

This doesn't seem to be caused by my bug 1831759 changes since I see the same problem using d&d of the virtual folder.

Comment 1

[Wayne Mery (:wsmwk)]

supernova related?

Comment 2

[gene smith]

(In reply to Wayne Mery (:wsmwk) from comment #1)

supernova related?

I don't think so. I just tried it with 102 and see the same thing.

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1835556 - Fix moving Maildir-based virtual folders. r=#thunderbird-reviewers

Comment 4

[Francesco]

Is this related to bug 533766?

Comment 5

[Hartmut Welpmann [:welpy-cw]]

(In reply to gene smith from comment #0)

Moving a virtual (search) folder within Local Folders that are maildir based, the move does not occur. See this error on console:

[Parent 1054589, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012 (NS_ERROR_FILE_NOT_FOUND): file /home/gene/mozilla2/comm/mailnews/local/src/nsMsgMaildirStore.cpp:438
JavaScript error: chrome://messenger/content/about3Pane.js, line 2458: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIMsgCopyService.copyFolder]

When a saved search is created, the mbox store creates an empty folder with the same name, while the maildir store does not. Moving such a virtual folder subsequently fails in https://searchfox.org/comm-central/rev/c74bfa0d95156f9f98329f250a0494bb31cf2a60/mailnews/local/src/nsMsgMaildirStore.cpp#594.

Move of virtual folder works OK on mbox based Local Folders.

When moving a virtual folder within an imap account/server, you can move it to any folder one time within a session. If you try to move it more than once back to the same folder, often the move does not occur. It also sometimes hits an "ENSURE_SUCCESS(rv, rv) here:
https://searchfox.org/comm-central/rev/a8a527d3a13553a492016f9dba13f09c758e1afc/mailnews/imap/src/nsImapMailFolder.cpp#7383
failing with NS_ERROR_FILE_ALREADY_EXISTS which will prevent the move. It works better with that line commented out, but doesn't really fix the problem.
Restarting tb clears the confusion and you can move the virtual folder anywhere within the same imap account again one time.

This is bug 533766 and has just been fixed. So xrefing this is fine, Francesco.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/49a8cff5206a
Fix moving Maildir-based virtual folders. r=BenC