1835570 - Full screen shortcut no longer displayed in menubar "View" menu nor hamburger menu (says "null" instead in that menu!)

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[:Gijs (he/him)]

Per Shane (aminomancer)'s comment on matrix, I think there are leftover references to key_fullScreen after the patch from bug 1821886 that will need updating, cf. https://searchfox.org/mozilla-central/search?q=key_fullScreen

I'm very sorry for not catching this in review.

Masayuki, are you able to take a look at this?

I suspect it will be a bit tedious to fix as I suspect the references cannot stay static now that the shortcut has been split into enter/exit ones. For the menubar macOS ifdef'd ones this is not so bad because there are already 2 menuitems, so they can just each point to the corresponding key element. But this doesn't solve the non-macOS case in the menubar, or the two references in nodeToShortcutMap which is used by the user-configurable toolbar button and the hamburger menu entry.

But perhaps it doesn't matter if the only use for key is the cosmetic fetching of the string used, and that is the same for both key elements?

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

As far as I've tested, the menu is not visible in the fullscreen mode. But yeah, I guess that setting key to key_fullScreen should work.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1835570 - Map fullscreen menu items and toolbar buttons to the shortcut key correctly r=Gijs!

Just forgetting to map them to new key_enterFullScreen. Note that both
key_enterFullScreen and key_exitFullScreen have same shortcut keys.
Therefore, mapping only to key_enterFullScreen must be fine for the
toggle UIs.

This patch does not contain the tests for checking the tooltip label on
the toolbar buttons because the shortcut key information does not appear
in the DOM tree.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acef8ddb67b4
Map fullscreen menu items and toolbar buttons to the shortcut key correctly r=Gijs

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/acef8ddb67b4