1835594 - browserAction toolbarbutton smaller in height than its toolbaritem

Status: NEW

(WebExtensions :: General, enhancement, P5)

Description

[jscher2000]

Attachment: Mismatching control dimensions

This came up on Mozilla Connect when a user observed that after positioning the mouse pointer at 0,0 of a maximized window, a click will activate a built-in toolbar button like the Firefox View button, but it will not activate an add-on button placed in that position using Customize. https://connect.mozilla.org/t5/discussions/i-can-t-click-on-the-add-on-icon-in-the-top-left-corner-of-the/m-p/32659/

Native buttons have a toolbarbutton as a direct child of the customization-container, and both click (to activate the button) and right-click (to summon the context menu) work over the full height of the customization-container.

Add-on buttons have a toolbarbutton as a child of toolbaritem which is a child of the customization-container. A right-click will trigger the context menu over the full height of the container (for example, 40 pixels on the nav bar, 44 pixels on the tabs bar), while a click will only activate the button within the smaller boundaries of the button (32x32 on the nav bar, 36x36 on the tabs bar).

It would be more consistent and convenient if an add-on button could be activated in the same manner as a native button. (I don't understand flex layout, so I don't know why it doesn't already work that way or how to fix it.)

Comment 1

[William Durand [:willdurand]]

I seem to recall that some buttons have specific logic to be clickable outside of their normal "area", e.g. the "back" button and, well, the firefox view button as well, apparently.

:dao should toolbar buttons be clickable at 0,0 in a maximized window by default? i.e. are extension buttons different than all the other "native" toolbar buttons? In any case, should we try to have the same behavior for all our toolbar buttons/widgets (extensions and not extensions buttons)?