1835598 - Fx add-on suggestion is displayed in different section depending on keyword used

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: add-on suggestions in different sections

Found in

• Fx 115.0a1

Affected versions

• Fx 115.0a1

Affected platforms

• Windows 10
• macOS
• Ubuntu

Precondintions
browser.urlbar.addons.featureGate set to true
browser.urlbar.suggest.addons set to true
browser.urlbar.quicksuggest.enabled set to true
browser.urlbar.suggest.quicksuggest.nonsponsored set to true
browser.urlbar.quicksuggest.dataCollection.enabled set to true
browser.urlbar.merino.enabled set to true
browser.urlbar.merino.providers set to amo
browser.urlbar.bestMatch.enabled set to true
browser.search.region set to US

Have RS connected to stage branch.

Steps to reproduce

1. Launch Firefox.
2. In the address bar type: read aloud.
3. Delete the input from step 2 and in the address bar, type: tts.

Expected result

• Firefox add-on suggestion is displayed in the same section.

Actual result

• Suggestions are displayed in different sections of the address bar drop-down.
• Suggestion from step 2 is displayed in the Firefox Suggest section.
• Suggestion from step 3 is displayed in the Top Pick section.

Regression range

• Not a regression.

Additional notes

• Please see the attachment for more details.

Comment 1

[Daisuke Akatsuka (:daisuke)]

It seems that the result for the query read aloud is from Merino, but for the tts is from RemoteSettings.
I can think of two things that the reason why both displayed positions are different.

• Different data is on Merino and RemoteSettins.
• Same data is on both, but there is no is_top_pick field.

In this issue case, it seems that the latter reason caused the problem.
If no is_top_pick field, we handle the RemoteSettings result as top pick by the following code, but not for Merino.
https://searchfox.org/mozilla-central/rev/f4d3fe187cf7dffa4c13b354bbde9bc47b5ccd3f/browser/components/urlbar/private/AddonSuggestions.sys.mjs#163

Drew,
This may lead same issues in the future as well, so, should we modify the above line to apply only there is is_top_pick field?

Comment 2

[Drew Willcoxon :adw]

It looks like Merino has stopped including is_top_pick in the response. I've asked Michelle about it on Slack.

I think you're right that Firefox should treat is_top_pick as being true by default if Merino doesn't include it. Let's make that change, being careful to still prefer the value set by Merino if it did set a value, whether it's true or false -- so, just like we do for the remote settings case, as you said (??).

Comment 3

[Drew Willcoxon :adw]

Oh I might have misunderstood what you meant here:

so, should we modify the above line to apply only there is is_top_pick field?

I think we should apply the same is_top_pick logic to Merino suggestions that we do to RS suggestions. i.e.: is_top_pick: suggestion.is_top_pick ?? true

We can do that by changing AddonSuggestions.makeResult() so it modifies the passed-in suggestion object, so it sets suggestion.is_top_pick to true if is_top_pick is not already present in the suggestion.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Drew!
I will try to do it in AddonSuggestions.makeResult() for both RS and Merino.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1835598: Handle suggestions provided by any provider as top picks if is_top_pick is undefined

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acd631722a01
Handle suggestions provided by any provider as top picks if is_top_pick is undefined r=adw

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/acd631722a01

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx115.0b3 on Windows 10 and Ubuntu 20. Add-on suggestion is displayed in the same section for both keywords.