1835614 - Display arguments names and values when logging javascript traces

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The old debugger tracer (bug 1071521) was logging arguments names and values,
it would be neat if the new tracer was also doing this.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1835614 - [devtools] Log function call arguments.

Introduce a new global option in the tracer to log values.

For now, it only triggers javascript function call arguments to be logged,
but this will also impact the incoming feature logging native function calls,
and also the other incoming feature to log the returned values.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1835614 - [devtools] Use a custom resource for traces.

This help reduce the RDP overhead by only transferring what is strictly necessary.
The console message resources bundles various useless attributes.
This should also help better display traces in the frontend.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60b933696a41
[devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/4501d1fb176a
[devtools] Log function call arguments. r=devtools-reviewers,fluent-reviewers,devtools-backward-compat-reviewers,nchevobbe

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for xpcshell failure on test_tracer.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/b1a538c15bb06198c626a8a66906e3e719a0f5bc
Log link: https://treeherder.mozilla.org/logviewer?job_id=440659690&repo=autoland&lineNumber=2756

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2284795de753
[devtools] Use a custom resource for traces. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/05a5c9023d79
[devtools] Log function call arguments. r=devtools-reviewers,fluent-reviewers,devtools-backward-compat-reviewers,nchevobbe

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/2284795de753
https://hg.mozilla.org/mozilla-central/rev/05a5c9023d79