1835695 - "Search with Google" is hidden for Rich Entities entries when accessed by keyboard

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Note
*

Found in

• 115.0a1 2023-05-29

Affected versions

• Nightly 115.0a1 2023-05-29

Tested platforms

• Affected platforms: Win 10 64-bit, OSX 10.14
• Unaffected platforms: -

Preconditions

• browser.urlbar.richSuggestions.featureGate set to true.
• Connect to stage-preview using RS devtools addon.
  Run the following snippet in the Browser Console: Services.prefs.getDefaultBranch("").setCharPref("browser.search.param.search_rich_suggestions", "fen")

Steps to reproduce

1. Type a popular keyword inside the Address Bar - Search suggestions are shown alongside Rich entities.
2. Navigate through the Rich suggestions list using TAB and Up/Down arrow keys.

Expected result
Rich entities are autofilled in the address bar, Search with Google is visible for each selection.

Actual result
Search with Google label is missing on keyboard selection, it is only visible on mouse hover.

Regression range

• Last good: 2023-05-22
• First bad: 2023-05-23
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5b6dc73ad880b4b0cff9756679675bd77c68a00b&tochange=4528705310aaf48f2821992409ddb444356112ff
• Potentially regressed by: bug 1832518

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daleharvey, since you are the author of the regressor, bug 1832518, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1832518

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1835695 - Ensure urlbar result action is shown on keyboard navigation. r=dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cb6793a3494
Ensure urlbar result action is shown on keyboard navigation. r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1cb6793a3494

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed in Firefox 116 beta 2, across OSes, while connected to stage and enrolled in a Rich Entities experiment. "Search with Google" is now visible on keyboard navigation.