1835696 - Navigation to typedef inside dependent class template specialization

Status: RESOLVED FIXED

(Webtools :: Searchfox, defect)

Description

[Botond Ballo [:botond]]

Steps to reproduce

Have Searchfox index the following code:

template <typename>
struct A  {
  using type = int;
};  

template <typename T>
void foo(typename A<T>::type);

Expected results

Navigation from the use of type goes to the definition.

Actual results

No navigation is offered at the use.

Comment 1

[Botond Ballo [:botond]]

Here, the kind of AST node containing the use is not an Expr, but a TypeLoc, so the relevant visit methods are Visit*TypeLoc().

The kind of TypeLoc here is DependentNameTypeLoc, which MozsearchIndexer is missing handling for.

Comment 2

[Botond Ballo [:botond]]

mozsearch repo PR: https://github.com/mozsearch/mozsearch/pull/635

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1835696 - Handle DependentNameTypeLoc in MozsearchIndexer. r=asuth

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f34b6289b38
Handle DependentNameTypeLoc in MozsearchIndexer. r=asuth DONTBUILD

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6f34b6289b38