1835723 - setUninstallURL should be updated to 1023

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[patrickkettner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36

Steps to reproduce:

browser.runtime.setUninstallURL(https://example.org?a={"a".repeat(300)});

Actual results:

It throws an error, that setUninstallURL can only take strings up to 255 in length

Expected results:

Chrome updated setUninstallURL to allow for strings of a length of 1023. Firefox should be updated to match

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[patrickkettner]

Attachment: Bug 1835723 - Increase setUninstallURL length limit to 1023

Chrome was updated to 1023, sending in a PR for firefox to have parity

Comment 3

[Rob Wu [:robwu]]

Patrick, not sure if you've seen my comment in the patch (https://phabricator.services.mozilla.com/D179403#5939217), but I cannot approve the patch when it is in a draft state.

Comment 4

[patrickkettner]

Thanks for the ping, rob! submitted

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1de5c0e8f978
Increase setUninstallURL length limit to 1023 r=extension-reviewers,robwu

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/1de5c0e8f978

Comment 7

[rbloor]

MDN documentation change made in setUninstallURL to 1023 #27309