1835787 - Remove check on startupReason from isMozillaExtension

Status: NEW

(WebExtensions :: General, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The isMozillaExtension helper funtion defined in Extension.jsm is internally referring to "addonData.recommendationState" to identify a Mozilla line extension.

Before Bug 1833209 that property was not part of the addonData when the extension was being started as part of the application startup, because recommendationState was included in the details stored in the Addon DB but not in the subset stored in the
activeAddons XPIStates data.

This bugzilla issue tracks removing the checks on the startupReason (and related exception), as a separate follow up to Bug 1833209 changes.

Comment 1

[Rob Wu [:robwu]]

The isMozillaExtension call is only used to conditionally grant permissions. We should only do that at install/update time, so regardless of what happens internally within the method, it doesn't impact actual behavior.

Here is more context on recommendationState: https://phabricator.services.mozilla.com/D179373#inline-994034