1835802 - Translating a page twice reverts the translation all the while the Translation icon still shows the page as translated

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Alex Cornestean]

Attachment: 2023-05-30_14h27_55.mp4

Affected versions:

• Nightly 115.0a1/20230529093707

Description:
When a page is translated twice using the same language combination, after the second translation the page reverts to its original language but the Translations icon remains in the translated state i.e. the icon is blue and the language box is displayed beside it.

Steps to reproduce:

1. Access https://es.wikipedia.org/wiki/Wikipedia:Portada
2. Manually translate the page OR Enable the “Always translate <<language>> function. It does not matter as long as the page is translated
3. Open the Translations panel once more and manually translate the page again
4. Notice the page reverts to the original language (Spanish), but the Translations icon is in the translated state (blue icon and language box)

Actual:

1. The page reverts to its original language upon translating the page twice
2. The Translations icon remains in the translated state (blue icon and language box)

Expected:

1. A second translation of the page should do nothing and not revert the page to its original language. In this case the Translations icon will be in the correct state and show the correct information.

OR

2. Since the page is reverted to its original language, the Translations icon should also revert states i.e. it should become black and the language box should be gone

Comment 1

[Erik Nordin [:nordzilla]]

Thanks for filing this!

It looks like we missed the logic for disabling the Translate button in the revisit panel when applying the most recent UX feedback to update the panel views.

The expected behavior is that the Translate button should be disabled and the page should not be translatable a second time.

Greg, do you have a moment to look into this? It should be a trivial fix.

Comment 2

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835802 - Disable the translate button when the selection is the same as the requested translation; r?nordzilla!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e666f50a9f73
Disable the translate button when the selection is the same as the requested translation; r=nordzilla

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e666f50a9f73

Comment 5

[Alex Cornestean]

Verified as Fixed on the latest Nightly (115.0a120230531041723). Tested on Windows 10 x64 and macOS 11.3.1

The “Translate” button is disabled (faded out) when attempting to translate the page again using the same language combination. This includes both the “Translate” button from the panel opened via the URL bar icon and the panel opened via the “Translate page…” option in the Main Menu.

For further details, see the attached screenshot.

Comment 6

[Alex Cornestean]

Attachment: 2023-05-31_13h50_09.png