1835824 - Add schema validation testing for search-configuration

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Although we have the search configuration schema, we don't currently validate the search-config against the schema except via searchengine-devtools.

I think we should have the validation run in tests as well, as we don't always run searchengine-devtools straight away and automated tests would be the better place to catch this.

As part of the schema validation, we should also add additional checking that no additionalProperties are provided for objects. We don't deny additional properties for the live schemas, since we need to be able to cope with older clients receiving new properties. However, we should deny it in tests, so that we can make sure any new properties are added to the schema.

Comment 1

[Mark Banner (:standard8)]

I think I've got something working after discussing with Barret that there's JsonSchema in the tree (which is more what we need than the other in-tree JsonSchemaValidator).

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1835824 - Add a test to validate search-config against the schema. r?#search-reviewers!

This will also ensure that if we add new properties to the search-config, we'll also need to add them to the schema.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0c6cebd70d
Add a test to validate search-config against the schema. r=search-reviewers,mcheang,daleharvey

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8a0c6cebd70d