1835844 - Move scrollend-event-fired-for-programmatic-scroll.html test cases to variants

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P5)

Description

[Dan Robertson (:dlrobertson)]

Summary

The subtests in dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html creates an array of tests and runs a set of steps for each element.

It would be nice if each of these was split out into a variant.

Steps to Fix

1. Split dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html into two tests:
   a) Something like dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-call.html for the first test group
   b) Something like dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-attribute-setter.html for the second test group
2. Add "keys" to the test arrays, <meta name="variant" content="?include=<some key here>"> tags, and subsetTestByKey instead of a custom test loop.

Comment 1

[LyScott123]

Hello! Is this a mentored bug? Would love to work on this one if its available!

Comment 2

[Dan Robertson (:dlrobertson)]

(In reply to LyScott123 from comment #1)

Hello! Is this a mentored bug? Would love to work on this one if its available!

Hi! It certainly is! Check out the Firefox Contributors’ Quick Reference or the more detailed Getting Set Up To Work On The Firefox Codebase, and once you have a local firefox build reach out to me here or feel free to reach out to me on the mozilla matrix (my handle is @dlrobertson).

Comment 3

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1835844 - Move some scrollend subtests to test variants. r=hiro,botond

Tests is scrollend-event-fired-for-programmatic-scroll.html execute
several subtests in a single promise_test call. This can make debugging
a intermittent failure a bit more difficult. Move the subtests to test
variants to hopefully make debugging intermittent failures a bit easier.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b7bc7da3f8
Move some scrollend subtests to test variants. r=hiro

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46344 for changes under testing/web-platform/tests

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/16b7bc7da3f8

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot