1835854 - import bookmarks rollout a11y visual issue

Status: NEW

(Firefox :: Messaging System, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: grafik.png

When one uses keyboard accessibility to tab to the "Not Now" button in the "Import Bookmarks" rollout, the buttons end up touching and looking strange. Thanks to Punam for finding this and pointing out that the "marginBlock": "-4px -28px" on the secondary_button label is likely in play here.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

This would probably affect any follow-up import bookmarks import experiments as well. Even if we don't fix it in the rollout, we will want to fix it before landing a bookmarks import spotlight into mozilla-central.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

We want to get this fixed and verified in an experiment so that it's ready to go for the next "Import bookmarks" experiment/rollout or landing into mozilla-central.

Comment 3

[Punam Dahiya [:pdahiya]]

This is issue in existing rollout which should end when we decide to land import bookmark in tree. Future experiment using similar layout should update recipe offtrain. Bug tracks fixing this issue when we decide to import bookmark land in tree.

Issue is not blocking existing live rollout, which can stay live.