1835865 - [Win HCM] Translate This Page icon is partially invisible while expanded or hovered when a translation is done

Status: VERIFIED FIXED

(Firefox :: Translations, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Win HCM - Translations panel toggle with a translation active - Panel opened.png

STR:

1. Ensure a High Contrast Mode is active on Windows OS by activating a HCM theme in the OS Settings > Accessibility > Contrast Theme > (i.e. Night Sky theme)
2. Ensure that Translations are activated via browser.translations.enable=true.
3. On a translatable website, navigate to and activate Translate this page toggle
4. On an opened Translations panel, navigate to and activate Translate button
5. When the translation is completed, verify Translate this page toggle button's icon is updated to show that the translation is active
6. When the translation is completed, using mouse, hover over the Translate this page toggle and verify its icon is still fully visible when it is active and hovered
7. Navigate to and activate the Translate this page toggle
8. Verify Translate this page toggle button's icon is still fully visible when it is active and expanded

Expected:

1. The Translate this page button would provide fully visible icon that, at the moment of reporting, includes a translation symbol and a badge for a selected language - both elements would be visible in all states, incl. hover and active. The control would be using HCM color pairs like SelectedItem and SelectedItemText for the color and background-color properties

Actual:

1. By default, the Translate this page button provides fully visible icon that, at the moment of reporting, includes a translation symbol and a badge for a selected language. But the translation symbol is not visible on hover and active states leaving only the language badge to be present on-screen.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Win HCM - Translations panel toggle with a translation active - Panel is hovered

The translations symbol is very subtle when hovered and it does not use a HCM color pair with the background

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1835865 - Fix translations panel active color on HCM theme; r?nordzilla

Depends on D183206

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9fe2d7384cb
Fix translations panel active color on HCM theme; r=nordzilla

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d9fe2d7384cb

Comment 6

[Daniel Bodea [:danibodea]]

I have reproduced this issue in Release v116.0.1 (Windows 11) using the steps from comment 0. The icon "Page translated from <language1> to <language2>" is incorrectly shown on hover when the modal is displayed; the Asian-like character disappears when the icon is hovered, only being displayed when it is NOT hovered.
This behavior no longer occurs in Beta v117.0b3 and Nightly v118.0a1.