1835889 - [wpt-sync] Sync PR 40310 - [scroll-start] Add scroll-start tests

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 40310 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40310
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

[scroll-start] Add scroll-start tests

scroll-start[1] should set the initial scroll position of a scroller
This is an alternative approach to crrev.com/c/4545951.

Some notes on the cases covered by these tests:

scroll-start-display-toggled.html: scroll-start should set the scroll position
of a scroller that is toggled from display:none to display:block (or other
display: causing a layout box to be newly created[2]).

scroll-start-overflow-toggled.html: scroll-start should not be affected by
toggling overflow.

scroll-start-fieldset.html: the scrollable area of a \<fieldset> is handled
slightly differently from other scrollers in blink.

scroll-start-root.html: scroll start should work when set on the root/document
scroller.

scroll-start-vertical-lr.html: scroll-start should work correctly in
horizontal as well as vertical writing modes.

scroll-start-with-anchor-navigation.html: scroll-start should not
override anchor navigation.

scroll-start-with-fragment-navigation.html: scroll-start should not
override fragment navigation.

scroll-start-with-scroll-snap.html: scroll-snap should not override
scroll-snap.

scroll-start-with-text-fragment-navigation.html: scroll-start should not
override text-fragment navigation.

scroll-start.html: generic scroll-start tests.

[1] https://drafts.csswg.org/css-scroll-snap-2/#scroll-start
[2] https://drafts.csswg.org/css-scroll-snap-2/#toggling-display-none

Bug: 1439807
Change-Id: Ib59e98de9b1752cf78b89d00c0fe0330fb3f09ca
Reviewed-on: https://chromium-review.googlesource.com/4569089
WPT-Export-Revision: c8b6c0275cc7f2657e7408cc2ddaf665367ccaba

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5983fd65cebf9a5463961f95ab2d0fffcf3f4c14

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9ebb9cb775b623e6d2a4d7fd47dcb2ee98027c2

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests and 1 subtests

Status Summary

Firefox

OK : 12
PASS: 2
FAIL: 11

Chrome

OK : 12
PASS: 3
FAIL: 10

Safari

OK : 12
PASS: 3
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /css/css-scroll-snap-2/scroll-start-with-text-fragment-navigation.html [wpt.fyi]
  • scroll-start doesn't override text fragment navigation: FAIL

New Tests That Don't Pass

• /css/css-scroll-snap-2/scroll-start-display-toggled.html [wpt.fyi]
  • scroll-start does not interfer with recovering saved scroll position after display toggle: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-fieldset.html [wpt.fyi]
  • scroll-start sets default position of fieldset element: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-overflow-toggled.html [wpt.fyi]
  • scroll-start sets scroller position if overflow is not visible: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-root.html [wpt.fyi]
  • scroll-start sets the initial scroll position of the document: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-vertical-lr.html [wpt.fyi]
  • scroll-start sets initial scroll offset correctly in vertical writing modes: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-with-anchor-navigation.html [wpt.fyi]
  • scroll-start does not override anchor navigation.: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-with-programmatic-scroll.html [wpt.fyi]
  • scroll-start is not applied after a programmatic scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-with-scroll-snap.html [wpt.fyi]
  • scroller snaps based on scroll-start position: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start-with-text-fragment-navigation.html [wpt.fyi]
  • scroll-start doesn't override text fragment navigation: FAIL (Chrome: PASS, Safari: PASS)
• /css/css-scroll-snap-2/scroll-start-with-user-scroll.html [wpt.fyi]
  • scroll-start is not applied after user a scroll: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-scroll-snap-2/scroll-start.html [wpt.fyi]
  • CSS Scroll Snap 2 Test: scroll-start-*: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d0b6b72f3b3
[wpt PR 40310] - [scroll-start] Add scroll-start tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f3e5b8ebfe7c
[wpt PR 40310] - Update wpt metadata, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3d0b6b72f3b3
https://hg.mozilla.org/mozilla-central/rev/f3e5b8ebfe7c