1835892 - Wrong dashes in Device Migration Spotlight subtitle EN string

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Shane Hughes [:aminomancer]]

This string has double en dashes, but (per Acorn) it should have a single em dash —.

This isn't a critical issue and won't block the experiment. The string has already been translated, and translators have done their own thing with the dashes. So there's no need to change the ID to restart translation. We can just change the EN strings in-place, and let it ride the trains for 115 or 116.

The needed changes are very simple:

diff --git a/browser/locales/en-US/browser/newtab/asrouter.ftl b/browser/locales/en-US/browser/newtab/asrouter.ftl
index 6615a601fa70c..53b6515cec100 100644
--- a/browser/locales/en-US/browser/newtab/asrouter.ftl
+++ b/browser/locales/en-US/browser/newtab/asrouter.ftl
@@ -244,6 +244,6 @@ fxa-sync-cfr-secondary = Remind me later
 ## Device Migration FxA Spotlight

 device-migration-fxa-spotlight-header = Using an older device?
-device-migration-fxa-spotlight-body = Back up your data to make sure you don’t lose important info like bookmarks and passwords –– especially if you switch to a new device.      
+device-migration-fxa-spotlight-body = Back up your data to make sure you don’t lose important info like bookmarks and passwords — especially if you switch to a new device.       
 device-migration-fxa-spotlight-primary-button = How to back up my data
 device-migration-fxa-spotlight-link = Remind me later

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1835892 - Fix dash in Device Migration Spotlight subtitle EN string. r?flod

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c47daffc9229
Fix dash in Device Migration Spotlight subtitle EN string. r=flod,fluent-reviewers

Comment 3

[Shane Hughes [:aminomancer]]

Comment on attachment 9337499 [details]
Bug 1835892 - Fix dash in Device Migration Spotlight subtitle EN string. r?flod

Beta/Release Uplift Approval Request

• User impact if declined: EN users will see unconventional double en-dashes in the Device Migration Spotlight message's sub-heading, instead of the standard single em-dash.

Ideally, we would like to uplift this for the 114 dot-release in addition to beta, since the message will be targeting 114+ users.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only changes the English version of a single string. Not a critical uplift by any means but very low risk.
• String changes made/needed: The patch changes an English string, but without triggering new translations, since only the EN string was affected by the bug.
• Is Android affected?: No

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c47daffc9229

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9337499 [details]
Bug 1835892 - Fix dash in Device Migration Spotlight subtitle EN string. r?flod

Approved for 115 beta, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/5f036ce2680a

Comment 7

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 116.0a1 (Build Id: 20230613092556) and Firefox Beta 115.0b5 (Build Id: 20230613195413) on Windows 8.1 and I can confirm that the subtitle from the Device Migration spotlight does not contain double dashes anymore.

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9337499 [details]
Bug 1835892 - Fix dash in Device Migration Spotlight subtitle EN string. r?flod

Approved for 114.0.2, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/406fb04e65f2

Comment 10

[Alice Varro [avarro], Ecosystem QA]

I have verified this issue using Firefox Release 114.0.2 (Build ID: 20230619081400) on Windows 8.1 and I can confirm that the subtitle from the Device Migration spotlight does not contain double dashes anymore.