Closed Bug 1835994 Opened 1 years ago Closed 1 year ago

[wpt-sync] Sync PR 40316 - webrtc wpt: restore mid extension locally in simulcast tests

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40316 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40316
Details from upstream follow.

phancke@microsoft.com <phancke@microsoft.com> wrote:

webrtc wpt: restore mid extension locally in simulcast tests

which is mandatory to implement per
https://datatracker.ietf.org/doc/html/rfc8853#section-5.5

BUG=chromium:1422258

Change-Id: I3f04492a6379f11c58a77e18d91cff37c26e3009
Reviewed-on: https://chromium-review.googlesource.com/4572428
WPT-Export-Revision: 3883eb1e2ae7bdd106c6b7eee4c6ecfb102a06fe

PR 40316 applied with additional changes from upstream: 57864686cea2142a2fa677501996c2fcb91bbb9a, db1ac12ce7bb790ae98a1d03a22b54b55b2a93d2
Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 5 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 14 tests and 18 subtests

Status Summary

Firefox

OK : 11[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 14[GitHub]
PASS : 36[GitHub] 39[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt]
FAIL : 26[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 32[GitHub]

Chrome

OK : 13
PASS : 22
FAIL : 45
TIMEOUT: 2

Safari

OK : 8
PASS : 13
CRASH : 2
FAIL : 33
TIMEOUT: 8
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
    • Simulcast getStats results: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: CRASH)
    • Remote reanswer altering rids does not throw an exception.: FAIL (Chrome: PASS)
  • /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
    • Basic simulcast setup with three spatial layers: FAIL (Chrome: PASS, Safari: FAIL)
  • /webrtc/simulcast/h264.https.html [wpt.fyi]
    • H264 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/negotiation-encodings.https.html [wpt.fyi]
    • addTrack, then sRD(simulcast recv offer) results in simulcast: FAIL (Chrome: FAIL, Safari: FAIL)
    • sRD(simulcast offer) can narrow the simulcast envelope from a previous negotiation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Duplicate rids in sRD(offer) are ignored: FAIL (Chrome: FAIL, Safari: FAIL)
    • Choices in rids in sRD(offer) are ignored: FAIL (Chrome: FAIL, Safari: FAIL)
    • Reordering of rids in sRD(reoffer) is ignored: FAIL (Chrome: PASS, Safari: PASS)
    • sRD(simulcast offer) can narrow the simulcast envelope from a previous negotiation by removing the first encoding: FAIL (Chrome: FAIL, Safari: FAIL)
  • /webrtc/simulcast/setParameters-encodings.https.html [wpt.fyi]
    • Success task for setLocalDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
    • Success task for setRemoteDescription(offer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
    • Success task for setRemoteDescription(answer) clears [[LastReturnedParameters]]: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: FAIL)
  • /webrtc/simulcast/vp8.https.html [wpt.fyi]
    • VP8 simulcast setup with two streams: FAIL (Chrome: PASS, Safari: PASS)
  • /webrtc/simulcast/vp9-scalability-mode.https.html [wpt.fyi]
    • VP9 simulcast setup with two streams and L1T2 set: FAIL (Chrome: PASS, Safari: TIMEOUT)
  • /webrtc/simulcast/vp9.https.html [wpt.fyi]
    • VP9 simulcast setup with two streams: FAIL (Chrome: TIMEOUT, Safari: TIMEOUT)
  • /webrtc-extensions/RTCRtpParameters-codec.html [wpt.fyi]
    • Creating an audio sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
    • Creating a video sender with addTransceiver and codec should work: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting codec on an audio sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting codec on a video sender with setParameters should work: FAIL (Chrome: FAIL, Safari: FAIL)
    • Creating an audio sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Creating a video sender with addTransceiver and non-existing codec should throw OperationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-existing codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-existing codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-preferred codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-preferred codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-negotiated codec on an audio sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Setting a non-negotiated codec on a video sender with setParameters should throw InvalidModificationError: FAIL (Chrome: FAIL, Safari: FAIL)
    • Codec should be undefined after negotiating away the currently set codec on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
    • Codec should be undefined after negotiating away the currently set codec on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stats output-rtp should match the selected codec in non-simulcast usecase on an audio sender: FAIL (Chrome: FAIL, Safari: FAIL)
    • Stats output-rtp should match the selected codec in non-simulcast usecase on a video sender: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /webrtc/simulcast/getStats.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
  • /webrtc/simulcast/rid-manipulation.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: CRASH)
  • /webrtc-encoded-transform/RTCPeerConnection-insertable-streams-simulcast.https.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8754878b33b [wpt PR 40316] - webrtc wpt: restore mid extension locally in simulcast tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/bb6001611ddc [wpt PR 40316] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a8754878b33b
https://hg.mozilla.org/mozilla-central/rev/bb6001611ddc

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
Depends on: 1903142
No longer regressions: 1903142
You need to log in before you can comment on or make changes to this bug.