Take check for requested GC out of the nursery allocation fast path
Categories
(Core :: JavaScript: GC, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox116 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
(Keywords: perf-alert, Whiteboard: [sp3])
Attachments
(1 file)
Currently we check for a requested GC (both major and minor) at the start of every allocation.
We can take this check out of the nursery allocation path and handle this by setting the nursery position to the end of the current chunk when a minor GC is requested.
Assignee | ||
Comment 1•2 years ago
|
||
This allows us to fold the check for this into the space check for nursery
allocations.
This change also means we don't trigger requested major GC on nursery
allocations. We still trigger this via interrupts.
This also separates the interrupt bits for minor and major GCs.
Updated•2 years ago
|
Updated•2 years ago
|
Comment 3•2 years ago
|
||
bugherder |
Comment 4•2 years ago
|
||
(In reply to Pulsebot from comment #2)
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5539060a841c
Set nursery position to the end of the chunk when minor GC is requested
r=jandem
== Change summary for alert #38633 (as of Fri, 09 Jun 2023 07:34:48 GMT) ==
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) | Performance Profiles |
---|---|---|---|---|---|
51% | fandom loadtime | windows10-64-shippable-qr | bytecode-cached cold fission webrender | 2,196.90 -> 1,072.07 | Before/After |
46% | fandom SpeedIndex | windows10-64-shippable-qr | bytecode-cached cold fission webrender | 1,014.17 -> 543.68 | Before/After |
46% | fandom PerceptualSpeedIndex | windows10-64-shippable-qr | bytecode-cached cold fission webrender | 903.72 -> 487.83 | Before/After |
43% | fandom LastVisualChange | windows10-64-shippable-qr | bytecode-cached cold fission webrender | 1,356.81 -> 771.79 | Before/After |
39% | fandom ContentfulSpeedIndex | windows10-64-shippable-qr | bytecode-cached cold fission webrender | 863.69 -> 526.06 | Before/After |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38633
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
(In reply to Alex Finder from comment #4)
I don't know what happened here but these perf changes look like a temporary glitch and not related to this change.
Description
•