1836094 - Hazard analysis failures are not causing the job to fail

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

The hazard analysis is logging errors and creating artifacts for them, but the build is showing up green.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1836094 - look in the correct file for hazards to fail the job

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1836094 - remove remaining references to rootingHazards.txt

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817092

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6602e057003
look in the correct file for hazards to fail the job r=jonco
https://hg.mozilla.org/integration/autoland/rev/0ef227655399
remove remaining references to rootingHazards.txt r=jonco

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a6602e057003
https://hg.mozilla.org/mozilla-central/rev/0ef227655399

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sfink, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9336817 [details]
Bug 1836094 - look in the correct file for hazards to fail the job

Beta/Release Uplift Approval Request

• User impact if declined: It's more on our side, where test failures may be missed, and they are test failures that may indicate security bugs.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1832284, Bug 1835989
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There is no risk from these patches themselves, they're just exposing any errors that occur. But it is only landable if there are no errors, and that depends on fixing up the existing errors, so whichever of the dependent bugs needs to land first will need to do that.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9336817 [details]
Bug 1836094 - look in the correct file for hazards to fail the job

I talked to RyanVM, who pointed out that any errors that got backported would first land on the main branch and so would get checked by a correctly functioning analysis there.