1836121 - Update PDF.js to new version a2118f52b0583100474a32763c9650ecb9a988cb from 2023-05-31 13:56:45

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 10 commits.. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/content/build/pdf.js | 172 +++++++++-----
toolkit/components/pdfjs/content/build/pdf.scripting.js | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.js | 29 +-
toolkit/components/pdfjs/content/web/viewer-geckoview.js | 105 ++++-----
toolkit/components/pdfjs/content/web/viewer.js | 145 +++++-------
toolkit/components/pdfjs/moz.yaml | 4 +-
6 files changed, 237 insertions(+), 222 deletions(-)

---

133d10318630d73828dc4cb336a1e18e569802a8 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/133d10318630d73828dc4cb336a1e18e569802a8
Authored: 2023-05-30 18:24:49 +0200
Committed: 2023-05-31 15:43:07 +0200

[Editor] Add few more info when saving ink data (thickness, opacity, ...)

Fix the InkList entry: the coordinates were relative to the page and not
to the bounding box of the annotation.

Files Modified:

• src/core/annotation.js
• src/display/editor/ink.js
• test/test_manifest.json
• test/unit/annotation_spec.js

---

ca620e4cc9e415190c012a7031be803cb0f76f80 by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/ca620e4cc9e415190c012a7031be803cb0f76f80
Authored: 2023-05-29 14:46:31 +0200
Committed: 2023-05-29 15:45:24 +0200

Update Puppeteer to version 20

This commit makes the following required changes:

• Replace custom cache trimming logic in favor of the (per our request)
  newly added trimCache method in Puppeteer. Not only does this greatly
  simplify our code and prevents having to import Puppeteer internals,
  it's also necessary because Puppeteer 20 removed the BrowserFetcher
  API in favor of the new separate @puppeteer/browsers package.
• Start browsers in series instead of in parallel. Parallel browser
  starts broke since Puppetter 19.1.0 and it turns out that it has never
  been supported officially, so it worked more-or-less by accident.
  Starting browsers in series is the supported way, is almost equally
  fast and ensures that we avoid any race conditions during startup.
  Finally, it also allows us to remove the browserPromise state on our
  session objects.

Fixes #15865.

Files Modified:

• package-lock.json
• package.json
• test/test.js

---

1096e69879fa01c59baccb185379fec105b3468a by Tim van der Meij

https://github.com/mozilla/pdf.js/commit/1096e69879fa01c59baccb185379fec105b3468a
Authored: 2023-05-29 14:16:43 +0200
Committed: 2023-05-29 14:16:43 +0200

Bump versions in pdfjs.config

Files Modified:

• pdfjs.config

---

78e6020a6e9ead3c207ef8ea4a82fce5a9a8301a by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/78e6020a6e9ead3c207ef8ea4a82fce5a9a8301a
Authored: 2023-05-28 17:47:04 +0200
Committed: 2023-05-28 19:03:37 +0200

[OTS] Remove cntrmask instruction with no stem in charstring (bug 1529502)

Files Added:

• test/pdfs/bug1529502.pdf

Files Modified:

• src/core/cff_parser.js
• test/pdfs/.gitignore
• test/test_manifest.json

---

c4c8227d20b2a1662e8e119bfcabe2ca6e8738cc by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/c4c8227d20b2a1662e8e119bfcabe2ca6e8738cc
Authored: 2023-05-28 12:30:18 +0200
Committed: 2023-05-28 17:54:34 +0200

Re-factor updating of thumbnails in the PDFSidebar-class

This patch does two things:

• Moves the updating of thumbnails into web/app.js, via a new PDFSidebar callback-function, to avoid having to include otherwise unnecessary parameters when initializing a PDFSidebar-instance.
• Only attempt to generate thumbnail-images from pages that are cached in the viewer. Note that only pages that exist in the PDFPageViewBuffer-instance can be rendered, hence it's not actually meaningful to check every single page when updating the thumbnails.
  For large documents, with thousands of pages, this should be a tiny bit more efficient when e.g. opening the sidebar since we no longer need to check pages that we know have not been rendered.

Files Modified:

• web/app.js
• web/pdf_sidebar.js
• web/pdf_viewer.js

---

0e604f8f42c378f4385f7498f44078c51a03c348 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/0e604f8f42c378f4385f7498f44078c51a03c348
Authored: 2023-05-28 12:30:11 +0200
Committed: 2023-05-28 15:33:23 +0200

Use local variables more in PDFViewerApplication._initializeViewerComponents

Files Modified:

• web/app.js

---

b51bbdf055853ab9ac6c119d929b35d82d7bee7a by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/b51bbdf055853ab9ac6c119d929b35d82d7bee7a
Authored: 2023-05-28 09:44:15 +0200
Committed: 2023-05-28 09:44:15 +0200

Update l10n files

Files Modified:

• l10n/cs/viewer.properties
• l10n/de/viewer.properties
• l10n/dsb/viewer.properties
• l10n/es-ES/viewer.properties
• l10n/fa/viewer.properties
• l10n/fi/viewer.properties
• l10n/fy-NL/viewer.properties
• l10n/gl/viewer.properties
• l10n/gn/viewer.properties
• l10n/is/viewer.properties
• l10n/ja/viewer.properties
• l10n/ka/viewer.properties
• l10n/kab/viewer.properties
• l10n/nb-NO/viewer.properties
• l10n/pt-PT/viewer.properties
• l10n/rm/viewer.properties
• l10n/ru/viewer.properties
• l10n/sc/viewer.properties
• l10n/sl/viewer.properties
• l10n/sr/viewer.properties
• l10n/th/viewer.properties
• l10n/zh-TW/viewer.properties

---

0e129c9e5e1bee113e6ab64ff8aa335146dc3623 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/0e129c9e5e1bee113e6ab64ff8aa335146dc3623
Authored: 2023-05-28 09:39:34 +0200
Committed: 2023-05-28 09:39:34 +0200

Update npm packages

Files Modified:

• package-lock.json
• package.json

---

bc8523ac2947d0bacc6b13a6105a037b8d9c5dcd by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/bc8523ac2947d0bacc6b13a6105a037b8d9c5dcd
Authored: 2023-05-25 14:29:30 +0200
Committed: 2023-05-26 15:30:22 +0200

Introduce a "thumbnailrendered" event to simplify cleanup after thumbnail rendering (PR 12613 follow-up)

The way that the cleanup was implemented in PR 12613 has always bothered me slightly, since the isPageCached-method that I introduced there always felt quite out-of-place in the IPDFLinkService-implementations.
By introducing a new "thumbnailrendered" event, similar to the existing "pagerendered" one, we're able to move the cleanup handling into the PDFViewer-class instead.

Files Modified:

• web/app.js
• web/interfaces.js
• web/pdf_link_service.js
• web/pdf_thumbnail_view.js
• web/pdf_thumbnail_viewer.js
• web/pdf_viewer.js

---

d0bf505312c7fd00024d2f55e094c519a0bb86b0 by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/d0bf505312c7fd00024d2f55e094c519a0bb86b0
Authored: 2023-05-26 10:31:54 +0200
Committed: 2023-05-26 13:59:39 +0200

Re-factor the isPageVisible-handling in the find-controller (PR 10217 follow-up)

The way that this was implemented in PR 10217 has always bothered me slightly, since the isPageVisible-method that I introduced there always felt quite out-of-place in the IPDFLinkService-implementations.
Hence this is instead replaced by a callback-function in PDFFindController, to handle the page-visibility checks. Note that since the PDFViewer-constructor always sets this callback-function, e.g. the viewer-component examples still work as-is.

Files Modified:

• web/interfaces.js
• web/pdf_find_controller.js
• web/pdf_link_service.js
• web/pdf_viewer.js

---

Comment 1

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=3686714b0d242cc5a54526443cede2c42c955169

Comment 2

[Update Bot]

Attachment: Bug 1836121 - Update PDF.js to a2118f52b0583100474a32763c9650ecb9a988cb

Comment 3

[Update Bot]

All the jobs in the try run succeeded. Like literally all of them, there weren't
even any intermittents. That is pretty surprising to me, so maybe you should double
check to make sure I didn't misinterpret things and that the correct tests ran...

Anyway, I've done all I can, so I'm passing to you to review and land the patch.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b68271768e
Update PDF.js to a2118f52b0583100474a32763c9650ecb9a988cb r=pdfjs-reviewers,calixte

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d2b68271768e