1836127 - Nullable union used as callback arguments needs to be actually declared

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(this bug is split off from bug 1556358)

We would like to use a nullable union for formStateRestoreCallback in bug 1556358 and got following error:

2:34.98 /home/edgar/.mozbuild/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7/../../../../include/c++/7/type_traits:1448:10: error: incomplete type 'mozilla::dom::FileOrUSVStringOrFormData' used in type trait expression
2:34.98 __has_trivial_destructor(_Tp)>>
2:34.98 ^
2:34.98 /home/edgar/.mozbuild/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/7/../../../../include/c++/7/type_traits:3018:5: note: in instantiation of template class 'std::is_trivially_destructiblemozilla::dom::FileOrUSVStringOrFormData' requested here
2:34.98 is_trivially_destructible<_Tp>::value;
2:34.98 ^
2:34.98 /home/edgar/Workspace/mercurial/mozilla-central/objdir-debug/dist/include/mozilla/MaybeStorageBase.h:20:10: note: in instantiation of variable template specialization 'std::is_trivially_destructible_vmozilla::dom::FileOrUSVStringOrFormData' requested here
2:34.98 std::is_trivially_destructible_v<T> &&
2:34.98 ^
2:34.98 /home/edgar/Workspace/mercurial/mozilla-central/objdir-debug/dist/include/mozilla/Maybe.h:239:27: note: in instantiation of variable template specialization 'mozilla::detail::IsTriviallyDestructibleAndCopyablemozilla::dom::FileOrUSVStringOrFormData' requested here
2:34.98 IsTriviallyDestructibleAndCopyable<T>>
2:34.98 ^
2:34.98 /home/edgar/Workspace/mercurial/mozilla-central/objdir-debug/dist/include/mozilla/Maybe.h:350:23: note: in instantiation of default argument for 'MaybeStoragemozilla::dom::FileOrUSVStringOrFormData' required here
2:34.98 : private detail::MaybeStorage<T>,
2:34.99 ^~~~~~~~~~~~~~~
2:34.99 /home/edgar/Workspace/mercurial/mozilla-central/objdir-debug/dist/include/mozilla/dom/Nullable.h:25:12: note: in instantiation of template class 'mozilla::Maybemozilla::dom::FileOrUSVStringOrFormData' requested here
2:34.99 Maybe<T> mValue;
2:34.99 ^
2:34.99 /home/edgar/Workspace/mercurial/mozilla-central/objdir-debug/dist/include/mozilla/dom/CustomElementRegistryBinding.h:1481:17: note: in instantiation of template class 'mozilla::dom::Nullablemozilla::dom::FileOrUSVStringOrFormData' requested here
2:34.99 return Call(s.GetCallContext(), thisValJS, state, reason, aRv);

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: Bug 1836127 - Nullable union used as callback arguments needs to be actually declared; r?peterv

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/783bd8e8246e
Nullable union used as callback arguments needs to be actually declared; r=peterv

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/783bd8e8246e