1836148 - Figure out how to improve the signature of crashes involving hash tables (again)

Status: NEW

(Socorro :: Signature, task)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Bug 1795651 added some std::_Hash related things to the irrelevant signature list.

Unfortunately, the implementation of the std hashtable we use seems to have changed and now there's a bunch of junk in these signatures again.

bp-c72fd234-ba71-47e2-a32a-a58570230523

0  xul.dll  std::_Fnv1a_append_bytes  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/type_traits:2356
0  xul.dll  std::_Fnv1a_append_value  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/type_traits:2376
0  xul.dll  std::_Hash_representation  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/type_traits:2384
0  xul.dll  std::hash<unsigned long long>::_Do_hash  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/type_traits:2433
0  xul.dll  std::_Conditionally_enabled_hash<unsigned long long, 1>::operator const  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/type_traits:2411
0  xul.dll  std::_Uhash_compare<unsigned long long, std::hash<unsigned long long>, std::equal_to<unsigned long long> >::operator const  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/xhash:113
0  xul.dll  std::_Hash<std::_Umap_traits<unsigned long long, mozilla::layers::APZUpdater*, std::_Uhash_compare<unsigned long long, std::hash<unsigned long long>, std::equal_to<unsigned long long> >, std::allocator<std::pair<const unsigned long long, mozilla::layers::APZUpdater*> >, 0> >::_Hashval const  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/xhash:1125
0  xul.dll  std::_Hash<std::_Umap_traits<unsigned long long, mozilla::layers::APZUpdater*, std::_Uhash_compare<unsigned long long, std::hash<unsigned long long>, std::equal_to<unsigned long long> >, std::allocator<std::pair<const unsigned long long, mozilla::layers::APZUpdater*> >, 0> >::lower_bound  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/xhash:659
0  xul.dll  std::_Hash<std::_Umap_traits<unsigned long long, mozilla::layers::APZUpdater*, std::_Uhash_compare<unsigned long long, std::hash<unsigned long long>, std::equal_to<unsigned long long> >, std::allocator<std::pair<const unsigned long long, mozilla::layers::APZUpdater*> >, 0> >::find  /builds/worker/fetches/vs/VC/Tools/MSVC/14.16.27023/include/xhash:643
0  xul.dll  mozilla::layers::APZUpdater::GetUpdater  gfx/layers/apz/src/APZUpdater.cpp:420

Maybe these would be sufficient?
std::_Fnv1a
::_Do_hash
std::_Conditionally_enabled_hash
std::_Uhash

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Maybe std::_ should be even be in there? I see std::__ already.