1836167 - Android New Telemetry in Bookmarks

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[[:harrisono]]

1. bookmarks.add Type: labeled_counter Desc: counts the number of times a bookmark is added.

2. bookmarks.delete Type: labeled_counter Desc: counts the number of times a bookmark is deleted

3. bookmarks.edit Type:labeled_counter Desc: counts the number of times a bookmark is edited

4. bookmarks.open Type: labeled_counter Desc: counts the number of times a bookmark is opened

Comment 1

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1836167 - New telemetry in bookmarks for growth retention measurement (#2375)

Comment 2

[BMO Github Automation]

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/b07590329a99a1d7f616b43cd91b9b579cd1fbdd
[main] Bug 1836167 - New telemetry in bookmarks

Comment 3

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 116.0a1 from 06/25 with Motorola Moto G9 plus (Android 11).
The new telemetry has been added in metrics. The new labels count the number of times a bookmark is added/deleted/opened/edited:

"metrics.bookmarks_edit": {

    "bookmark_panel": 1

  },

  "metrics.bookmarks_delete": {

    "bookmark_panel": 2

  },

  "metrics.bookmarks_add": {

    "page_action_menu": 1

  },

  "metrics.bookmarks_open": {

    "bookmark_panel": 1

  }

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1836167 - Fix Bookmark Open telemetry (#4930)

Comment 5

[BMO Github Automation]

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/9903e627e388097b8a1ffa5f952c1e8afa9f72e7
[main] Bug 1836167 - Fix Bookmark Open telemetry

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1836167 - Fix Bookmark Open telemetry (backport #4930) (#5076)

Comment 7

[[:harrisono]]

Comment on attachment 9369934 [details] [review]
[mozilla-mobile/firefox-android] Bug 1836167 - Fix Bookmark Open telemetry (#4930)

Beta/Release Uplift Approval Request

• User impact if declined: none.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixing a metric event that was not being fired properly on Bookmark open.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Donal Meehan [:dmeehan]]

Comment on attachment 9369934 [details] [review]
[mozilla-mobile/firefox-android] Bug 1836167 - Fix Bookmark Open telemetry (#4930)

Moving uplift request to the backport PR attachment

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9371598 [details] [review]
[mozilla-mobile/firefox-android] Bug 1836167 - Fix Bookmark Open telemetry (backport #4930) (#5076)

Approved for Fenix 122.0b8

Comment 10

[BMO Github Automation]

Authored by https://github.com/HarrisonOg
https://github.com/mozilla-mobile/firefox-android/commit/176fe475eb897d0101957f819327c9234bcc466e
[releases_v122] Bug 1836167 - Fix Bookmark Open telemetry