1836289 - Early Hints image loads blocked by webextension ublock show broken image frame instead of hiding the image

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Comment 1

[Rob Wu [:robwu]]

Is there a STR (test case + expected vs actual behavior)?

And more details on why it's considered a bug?

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Bug 1836289 - Provide nsILoadContext to the hinted request, r=manuel

The problem that the image element not being removed is that the tabId is missing.
To make tabId available for the web extensions, we need to provide nsILoadContext to hinted requests.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: eh_test_site.zip

The node server that I used to reproduce this issue locally.

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Rob Wu [:robwu] from comment #1)

Is there a STR (test case + expected vs actual behavior)?

Please see the attached test code.
STR:

1. Run node server.js to start the server.
2. Open Firefox and install uBlock.
3. Navigate to https://localhost:4433
4. Use uBlock to block image.jpg.
5. Reload the page and you can observe that the image element is still visible.

The expected result is that the image element should be hidden.

And more details on why it's considered a bug?

After looking into uBlock's code, I found that cosmetic filtering in uBlock doesn't work because the early hinted preload request has no tabId.
To fix this, we should provide a nsILoadContext to the preload request.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e37c8d6f4be
Provide nsILoadContext to the hinted request, r=manuel,necko-reviewers

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing Bp-nu bustages in EarlyHintsService.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-build/dist/include/mozilla/net/EarlyHintsService.h:33:18: error: unknown type name 'nsIInterfaceRequestor'

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18688c9011d
Provide nsILoadContext to the hinted request, r=manuel,necko-reviewers

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/c18688c9011d