1836325 - Firefox "Provide search suggestions" and Firefox Suggest checkboxes are un-checked by default, despite the fact that it's actually enabled

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Visit about:preferences (Firefox Settings)
2. Type "Suggest" into the filter searchbox
3. Look at the checkbox for Provide search suggestions and (further down) the various checkboxes/sliders under Address Bar — Firefox Suggest

ACTUAL RESULTS:
All of the settings are shown as "off".

EXPECTED RESULTS:
All of these should be checked/enabled (except the last one for "Improve the Firefox search experience). They are in fact enabled, but Firefox is mistakenly showing them as disabled.

mozregression indicates that this was a regression from bug 1831259.

Note, these settings are particularly sensitive to display accurately, given that we have some new search suggestions UI that seems to be shipping to early-beta users, with this first checkbox being one of the things you have to turn off in order to disable that UI.

Comment 1

[Daniel Holbert [:dholbert]]

[Tracking Requested - why for this release]:

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering (captured in May 31 Nightly)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of actual rendering (captured in June 1st Nightly)

Comment 4

[Daniel Holbert [:dholbert]]

(I zoomed out so that all of the relevant UI would be visible.)

Two particularly-incoherent/concerning parts of the "actual rendering" / actual-results here:
(1) In the top part, we're showing an incoherent configuration ("provide search suggestions: no" but "show search suggestions in address bar results: yes")
(2) In the bottom part, we're showing all the checkboxes/sliders being off, and yet our info-box at the very bottom says "Based on your selections, you'll receive suggestions from the web, including sponsored sites."

(Both of these incoherent things make sense once you know that the settings are actually enabled under-the-hood, and we're just failling to reflect that in the UI)

Comment 5

[:Gijs (out for now; he/him)]

I don't see most of the "sensitive" UI because I'm not in the US. I can reproduce the top checkbox for "provide search suggestions" being wrong (unchecked when we'd expect it to be checked).

On the whole this makes very little sense to me - the refactoring should not impact how individual checkboxes behave.

Given the stage of the cycle I suggest we back out 1831259 and I investigate more without the time pressure.

Comment 6

[Donal Meehan [:dmeehan]]

Setting Fx115 to Fixed, the regressor was backed out
https://bugzilla.mozilla.org/show_bug.cgi?id=1831259#c11

Comment 7

[Daniel Holbert [:dholbert]]

Thanks! Yeah, let's close this as fixed-by-backout. (backout technically hasn't hit central yet but it will soon.)

Comment 8

[:Gijs (out for now; he/him)]

(In reply to Daniel Holbert [:dholbert] from comment #7)

Thanks! Yeah, let's close this as fixed-by-backout. (backout technically hasn't hit central yet but it will soon.)

Bit confused by this because I think the comment linked pointed to this push which had landed at the time. https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=bf811f65e32d6dadc0c73472c81a855f4c52451d

I guess what I'm saying is... if today's Nightly update doesn't fix this, please shout?! :-)

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to :Gijs (he/him) from comment #8)

(In reply to Daniel Holbert [:dholbert] from comment #7)

Thanks! Yeah, let's close this as fixed-by-backout. (backout technically hasn't hit central yet but it will soon.)

Bit confused by this because I think the comment linked pointed to this push which had landed at the time.

You're right :) I just assumed that the backout happened on autoland, and didn't look closely enough at bug 1831259 comment 11 to notice that it was in fact a m-c link.

Comment 10

[Daniel Holbert [:dholbert]]

Marking VERIFIED FIXED. Today's Nightly (115.0a1 (2023-06-02)) matches the "good" screenshot from comment 2, when I perform my comment 0 STR in a fresh profile.