Closed
Bug 1836351
Opened 2 years ago
Closed 2 years ago
[Tabs tray to Compose] Fix tab grid item's close button size
Categories
(Firefox for Android :: Tabs, defect, P2)
Tracking
()
VERIFIED
FIXED
117 Branch
| Tracking | Status | |
|---|---|---|
| firefox117 | --- | verified |
People
(Reporter: 007, Assigned: vdreghici)
References
Details
(Whiteboard: [fxdroid])
Attachments
(3 files)
Before.png
The close button in TabGridItem should be 20 instead of 24. Also swap out the solo Icon + clickable for an IconButton
The XML is misleading as the AppCompatImageButton is 24, but the asset is 20.
|
Reporter | |
Updated•2 years ago
|
Whiteboard: [fxdroid]
|
||
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → Vlad.DreghiciPopa
Status: NEW → ASSIGNED
|
||
Comment 1•2 years ago
|
||
|
|
||
Comment 2•2 years ago
|
||
Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/61d4759312320f06a242a8190ae35c299edeba9e
[main] Bug 1836351 - Decrease close button size for TabGridItem
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
|
||
Comment 3•2 years ago
|
||
Managed to reproduce the issue with 24 pixel close button on an earlier Nightly (117.0a1 from 2023-07-20) build.
Verified as fixed on the latest Nightly (117.0a1 from 2023-07-25) build.
The tab close button is the same size as on the one from the latest Beta 116.0b8 and RC 116.0.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified.
Status: RESOLVED → VERIFIED
|
|
||
Updated•2 years ago
|
Flags: qe-verify+
|
|
||
Comment 4•2 years ago
|
||
|
|
||
Comment 5•2 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•