Closed Bug 1836416 Opened 1 years ago Closed 1 year ago

[wpt-sync] Sync PR 40353 - Revert "Fix failed test offscreencanvas_transferrable.html"

Categories

(Core :: Graphics: Canvas2D, task, P4)

task

Tracking

()

RESOLVED FIXED
116 Branch
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40353 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40353
Details from upstream follow.

Yuki Shiino <yukishiino@chromium.org> wrote:

Revert "Fix failed test offscreencanvas_transferrable.html"

This reverts commit 8426314bed87d9cedf75334fdd251406f5527ea2.

Reason for revert: Suspicious about causing test failures of external/wpt/html/canvas/offscreen/manual/the-offscreen-canvas/offscreencanvas.transferrable.html
https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests/19685

Original change's description:

Fix failed test offscreencanvas_transferrable.html

Currently, when transfer offscreencanvas to worker and offscreencanvas already has a rendering context or the same offscreencanvas is transferred twice, the data clone error is thrown. According to the spec, the invalid state error should be thrown instead.

Bug: 1448662

Change-Id: Iba80ca91587e0557f205c2aad2a192b862935e3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4566693
Reviewed-by: Justin Novosad \<junov@chromium.org>
Commit-Queue: Yi Xu \<yiyix@google.com>
Cr-Commit-Position: refs/heads/main@{#1152178}

Bug: 1448662
Change-Id: Ie66ea82e09443378d8f95057e478b88e10bc8d68
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4583648
Auto-Submit: Yuki Shiino \<yukishiino@chromium.org>
Commit-Queue: Yuki Shiino \<yukishiino@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1152291}

Component: web-platform-tests → Graphics: Canvas2D
Product: Testing → Core
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6992f09cf70d [wpt PR 40353] - Revert "Fix failed test offscreencanvas_transferrable.html", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.