1836433 - [de] Wrong date format used for next payment on https://subscriptions.firefox.com/subscriptions

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

When checking the subscriptions page the next payment date is wrongly displayed when having the German translation of the page. There it looks like:

Ihre nächste Rechnung über ⁨59,88 €⁩ ist am ⁨06/02/2024⁩ fällig

Note that in German we do not have the month first but the day. The above date would instead mean the 6th of February, which is kinda confusing for subscribers.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:markh, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Chelsea Lewis]

Thank you for filing, we are looking into the issue and will report back with an update shortly.

Comment 3

[Bryan Olsson [:bolsson]]

This doesn't appear to be an issue with the localized string itself, but the incorrectly formatted date is being passed to it.

It seems like this is the culprit:
https://github.com/mozilla/fxa/blob/79bc2beb63b619d4a9b57fa33e4602ef958a895a/packages/fxa-payments-server/src/routes/Subscriptions/Cancel/CancelSubscriptionPanel.tsx#L73

getLocalizedDateString only returns an en locale formatted date (for fallback strings).
https://github.com/mozilla/fxa/blob/79bc2beb63b619d4a9b57fa33e4602ef958a895a/packages/fxa-payments-server/src/lib/formats.ts#L98-L115

Comment 4

[Chelsea Lewis]

Thanks Bryan! We have a fix that will be up for review shortly. Ideally this bug will be resolved in production when our current train ships on 28 June.

Comment 5

[Chelsea Lewis]

This fix will be in Production Wednesday 28 June. Marking "Done" - thanks again for the report.