1836448 - Show attention "dot" when an extension is quarantined from a domain

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

The attention "dot" should probably be shown when an extension is quarantined from a domain.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r?zombie!,rpl

Comment 2

[William Durand [:willdurand]]

Attachment: Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r?zombie!,rpl

Depends on D179780

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a86d5a3f177d
Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a86d5a3f177d

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c53eee1c466
Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_preferences_usage.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/450b0b19428d0b40bc4e93caac72f773d6f516c1
Log link: https://treeherder.mozilla.org/logviewer?job_id=418605195&repo=autoland&lineNumber=9528

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfe7d1f2bb2
Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/f03661a056f0
Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6bfe7d1f2bb2
https://hg.mozilla.org/mozilla-central/rev/f03661a056f0

Comment 9

[William Durand [:willdurand]]

Comment on attachment 9337677 [details]
Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r?zombie!,rpl

Beta/Release Uplift Approval Request

• User impact if declined: Users browsing one of the quarantined domains with extensions not monitored by Mozilla. This isn't a lot of users but it might be confusing for users to notice an add-on not working and nothing else. While there is a notification in the extensions panel, there is no UI hint to tell the user to open that panel. With these 2 patches, users should see the "notification dot" under an extension or the extensions button.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small 2-patch stack that has automated test coverage.
• String changes made/needed: Yes
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

:willdurand this request contains strings, can this ride the trains with Fx116?

Comment 11

[William Durand [:willdurand]]

Oops, yes. I edited the request because there are indeed new strings (2 I think, which are used elsewhere already). I am not too worried about riding the trains with Fx116 but we'll need to uplift these patches for ESR 115 in the future..

Comment 12

[Donal Meehan [:dmeehan]]

:flod any objections to this uplift request?
See Comment 10 and Comment 11

Comment 13

[Francesco Lodolo [:flod]]

To be honest, I would prefer not to uplift these patches (I raised concerns when the first part of the feature landed too late in the 115 cycle, and this is an inevitable consequence of that).

There is other work happening on 116 for this feature (about:addons integration). What's the plan for that? Are we enabling it on 115 without that part?

we'll need to uplift these patches for ESR 115 in the future

ESR is as string frozen as beta, you are not supposed to uplift features or patches with new strings. This goes against how we all agreed to manage branches in the rapid release cycle.

Comment 14

[William Durand [:willdurand]]

OK. In this case, let's not uplift these patches.