Closed Bug 1836566 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 40370 - Stop re-absolutization of out of flow insets for getComputedStyle()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40370 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40370
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Stop re-absolutization of out of flow insets for getComputedStyle()

When we getComputedStyle() of an inset property of an out-of-flow
element, if the value is 'auto', percent or calc, we currently redo
the absolutization from the ComputedStyle. This is error-prone, has
known failues in WPT, and makes it impossible to work with anchor
positioning (and especially position fallback).

As we have already absolutized these values during layout, this patch
simply caches them on LayoutResult to be passed to getComputedStyle().

Fixed: 1423493
Fixed: 1451020
Change-Id: Ib31f17304179d5e5b91c9d91c3e97386b904d0a2

Reviewed-on: https://chromium-review.googlesource.com/4583533
WPT-Export-Revision: 646b91ec73272f279e8eaf47838419e81d1d02d0

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26f3975eda5b [wpt PR 40370] - Stop re-absolutization of out of flow insets for getComputedStyle(), a=testonly https://hg.mozilla.org/integration/autoland/rev/2270365fa64b [wpt PR 40370] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/26f3975eda5b
https://hg.mozilla.org/mozilla-central/rev/2270365fa64b

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
You need to log in before you can comment on or make changes to this bug.