1836597 - livestreams on various austrian broadcasters don't start playing

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[[:philipp]]

on firefox 115 on windows 10 it is no longer possible to watch various livestreams from austrian tv channels of different sorts - the content keeps in a loading state/does not start playing.

some samples affected by this problem:

• https://tvthek.orf.at/livestreams (there are constantly changing urls per livestream - the ones currently streaming are marked with a red dot)
• https://www.puls24.at/live
• https://www.atv.at/livestream

(i'm not sure if this content is behind a geolock - perhaps it is necessary to use a vpn in order to access them)

this is the range where the bug first appeared, that i came up with with the help of mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa170b66896e1972488dc85979c3df6bd3a07ae6&tochange=f1ecfbba7ed20ecd0284b301ced7f055f4eae575

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1817997

:padenot, since you are the author of the regressor, bug 1817997, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Paul Adenot (:padenot)]

Attachment: WIP: Bug 1836597 - Properly implement operator== for TimeUnit that overflow int64_t.

Comment 3

[Paul Adenot (:padenot)]

Thanks for the report, this should work tomorrow (or the day after) in Nightly. Most of the streams we indeed restricted to Austrian IPs, but the Mozilla VPN allows exiting in Vienna, so I ended up being able to debug.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1836597 - Add more ToString methods on TimeUnit related classes. r?#media-playback-reviewers,alwu

Comment 5

[Paul Adenot (:padenot)]

We'll have to uplift this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5837a86ce2a
Add more ToString methods on TimeUnit related classes. r=media-playback-reviewers,chunmin
https://hg.mozilla.org/integration/autoland/rev/fd86f83d1b48
Properly implement operator== for TimeUnit that overflow int64_t. r=media-playback-reviewers,chunmin

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b5837a86ce2a
https://hg.mozilla.org/mozilla-central/rev/fd86f83d1b48

Comment 8

[Donal Meehan [:dmeehan]]

(In reply to Paul Adenot (:padenot) from comment #5)

We'll have to uplift this.

:padenot could you submit a beta uplift request when ready?

Comment 9

[[:philipp]]

thank you for the quick fix, i can confirm that the issue is resolved in nightly build 20230606040644

Comment 10

[Paul Adenot (:padenot)]

Comment on attachment 9337471 [details]
WIP: Bug 1836597 - Properly implement operator== for TimeUnit that overflow int64_t.

Beta/Release Uplift Approval Request

• User impact if declined: Some websites (especially live TV) have broken video playback.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a trivial problem that happens to be triggered by some live video websites, and is unit tested directly.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 11

[Donal Meehan [:dmeehan]]

Comment on attachment 9337471 [details]
WIP: Bug 1836597 - Properly implement operator== for TimeUnit that overflow int64_t.

Approved for 115.0b3.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9337474 [details]
Bug 1836597 - Add more ToString methods on TimeUnit related classes. r?#media-playback-reviewers,alwu

Approved for 115.0b3.

Comment 13

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/88f0d453503f
https://hg.mozilla.org/releases/mozilla-beta/rev/dc48c0d3502f