1836682 - Re-enable test_originControls_with_submenus in browser_ext_originControls.js on OSX

Status: RESOLVED DUPLICATE of bug 1836383

(WebExtensions :: General, task)

Description

[Rob Wu [:robwu]]

test_originControls_with_submenus in browser_ext_originControls.js was temporarily skipped in bug 1836279 because of failures on macOS (with a spike of failures reported in bug 1782555).

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1836682 - Add closeSubmenu and use it in browser_ext_originControls.js

The test_originControls_with_submenus test task was failing on macOS
because popup.hidePopup() did not actually close the submenu popup.

The openMenu(false) call can be used instead (called on the menu item
to which the popup is attached).

This patch also fixes some other hazards that can potentially trigger
intermittent test failures.

Comment 2

[Rob Wu [:robwu]]

There was already a bug (and a patch) before at bug 1836383. I'm going to close this as a duplicate over the older bug while I figure out how to consolidate the patches with Will (who authored a patch earlier in the other bug).