1836699 - backout bug 1768495 from beta 115

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Timothy Nikkel (:tnikkel)]

We still haven't fixed bug 1828587 (which was caused by bug 1768495). So we've been backing out bug 1768495 from beta so that we don't expose bug 1828587 to release again.

Bug 1830753 is tracking getting a forward fix for this issue so that we don't have to keep backing out and it looks like we understand the problem well now and are just working throw getting patches landed, so hopefully this will be the last time we need to do this backout.

Comment 1

[Timothy Nikkel (:tnikkel)]

[Tracking Requested - why for this release]: this is bug 1828587 (which we did a dot release for) but for 115, i'll post the backout patch and we can land it asap after merge day

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1836699. Back out bug 1768495 from beta 115. r?emilio,bradwerth

Comment 3

[Donal Meehan [:dmeehan]]

I'm going to uplift this to beta for fx115 and update the versions in the related regressions appropriately.
:tnikkel can you consider landing this too to end up in central for 116?
We've been carrying the regression for multiple cycles. Would be better to have central in a good state for Fx116 and then land the original patches with fixes, etc. when ready

Comment 4

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b6f8763d212

Comment 5

[Timothy Nikkel (:tnikkel)]

(In reply to Donal Meehan [:dmeehan] from comment #3)

I'm going to uplift this to beta for fx115 and update the versions in the related regressions appropriately.
:tnikkel can you consider landing this too to end up in central for 116?
We've been carrying the regression for multiple cycles. Would be better to have central in a good state for Fx116 and then land the original patches with fixes, etc. when ready

Yeah, it does feel like we just keep having to back this out, doesn't it?

We (Brad and myself) discussed this. The feeling was that since we understand this better now, and the patches in bug 1830753 are close to landing, that the goal for 116 is to land the forward fix in bug 1830753. If that fix looks like it will take longer than we thought we can re-evaluate. Does that seem reasonable?

Comment 6

[Dianna Smith [:diannaS]]

Thanks :tnikkel , that sounds reasonable to me, I'll keep an eye out for the fix. Ideally the fix is ready before Week 3 of the cycle(June 16) to give QA enough time to verify.

Comment 7

[Timothy Nikkel (:tnikkel)]

I'm gonna mark this as fixed, we did what we intended here, and the fix on mozilla-central has landed in bug 1830753 as well.