1836771 - Message-bar notification used in the extensions panel is largely ignored by a screen reader

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[William Durand [:willdurand]]

STR:

1. Fully install a non-recommended extension, e.g. https://addons.mozilla.org/en-US/firefox/addon/colorzilla/
2. Go to about:config and add a domain to extensions.quarantinedDomains.list, e.g. mozilla.ai
3. Open a new tab and go to mozilla.ai
4. Open the extensions panel by "clicking" the extensions button in the toolbar with keyboard navigation (F6 to reach the urlbar then a few tabs to go to the toolbar icons)

Expected:

The focus is on the "learn more" link and a user with a screen reader can understand what the link is referring to.

Actual:

The screen reader reads "learn more" and nothing else. This is confusing.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r?morgan!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11b7ac1d9f2f
Add aria attributes to the message-bar notification used in the extensions panel. r=ayeddi

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/11b7ac1d9f2f

Comment 4

[William Durand [:willdurand]]

Comment on attachment 9337468 [details]
Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r?morgan!

Beta/Release Uplift Approval Request

• User impact if declined: Users exposed to the notification (not a lot) who use a screen reader are impacted. The problem is that, for those users, there is no context at all that explains why there is this notification (the screen reader won't "see" it).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because it is a minor change (adding aria attributes) with test coverage. The whole quarantined domains feature is being verified by QA during the beta cycle (https://mozilla-hub.atlassian.net/browse/QA-1903).
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

Comment on attachment 9337468 [details]
Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r?morgan!

Approved for 115.0b4.

Comment 6

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a650dd490682