1836869 - Switch malloc_size_of_derive to syn 2/synstructure 0.13

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1836869 - Move malloc_size_of_derive as first-party into xpcom/rust.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1836869 - Switch malloc_size_of_derive to syn 2/synstructure 0.13.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/530d15a58ee6
Move malloc_size_of_derive as first-party into xpcom/rust. r=supply-chain-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/345be3af098b
Switch malloc_size_of_derive to syn 2/synstructure 0.13. r=xpcom-reviewers,nika

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e008e952bb10
Fix WebRender bustage. r=fix CLOSED TREE

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/530d15a58ee6
https://hg.mozilla.org/mozilla-central/rev/345be3af098b
https://hg.mozilla.org/mozilla-central/rev/e008e952bb10

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I dunno how much people still care about the standalone WR build on github but this PR broke it, since it makes the WR workspace reference a file that's outside the gfx/wr folder and that isn't synced to github.

https://github.com/servo/webrender/pull/4818

Comment 7

[Jeff Muizelaar [:jrmuizel]]

I care about this not being broken. Mike, is there something we can do to fix it?

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Also for general awareness, I asked in the servo zulip chat and Martin Robinson said he'd try vendoring WR directly into servo. That was a few weeks ago and I don't know if there's been any update since. https://servo.zulipchat.com/#narrow/stream/263398-general/topic/Webrender.20sync

Comment 9

[Mike Hommey [:glandium]]

I guess we could use a patch in top-level Cargo.toml rather than a full path in the dependency.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

Can you put up a patch to do that?

Comment 11

[Mike Hommey [:glandium]]

Can you file a new bug?

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Done: bug 1836869