Playing Videos on Tall Android Phones Shows purple bar
Categories
(Firefox for Android :: General, defect)
Tracking
()
People
(Reporter: cheapgood, Assigned: jackyzy823)
References
Details
Attachments
(3 files)
Steps to reproduce:
- Open Firefox Android
- Switch to Private Browsing
- Play the WWDC 2023 keynote in the browser - https://www.apple.com/apple-events/
- You will see a purple bar at the top of the phone while the video plays
Actual results:
You will see a purple bar at the top of your phone while the video plays.
This happens in private and non-private mode but is more obvious in private mode because of the purple color. This might happen on taller aspect ratio phones.
This probably started around Android 80 but I could never reproduce it reliably until the WWDC keynote.
Expected results:
You should not see browser chrome take up part of the screen while a video plays
Forgot to mention after step 3 you need to full screen the video
Comment 2•2 years ago
|
||
The severity field is not set for this bug.
:jonalmeida, could you have a look please?
For more information, please visit BugBot documentation.
Updated•2 years ago
|
Found another video with the same issue
https://www.ign.com/videos/xbox-vs-ftc-12-surprising-reveals-from-the-trial
And chance this can be re-evaluated? This makes watching videos on Firefox kind of unusable unless I want a giant burned in block on my oled screen.
Assignee | ||
Comment 4•2 years ago
|
||
Possible Fix
--- a/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/android/view/Activity.kt
+++ b/android-components/components/support/ktx/src/main/java/mozilla/components/support/ktx/android/view/Activity.kt
@@ -29,6 +29,7 @@ fun Activity.enterToImmersiveMode() {
@VisibleForTesting
internal fun Activity.setAsImmersive() {
+ window.setDecorFitsSystemWindows(false)
window.getWindowInsetsController().apply {
hide(WindowInsetsCompat.Type.systemBars())
systemBarsBehavior = WindowInsetsControllerCompat.BEHAVIOR_SHOW_TRANSIENT_BARS_BY_SWIPE
@@ -58,6 +59,7 @@ internal fun Activity.enableImmersiveModeRestore() {
fun Activity.exitImmersiveMode() {
ViewCompat.setOnApplyWindowInsetsListener(window.decorView, null)
+ window.setDecorFitsSystemWindows(true)
window.getWindowInsetsController().apply {
show(WindowInsetsCompat.Type.systemBars())
}
Reference : https://stackoverflow.com/questions/62643517/immersive-fullscreen-on-android-11
Comment 5•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.
Comment 8•2 years ago
|
||
Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/a2a11dfa0b2241b9057441951372ff297d9705bc
[main] Bug 1836896 - Hide statusbar when fullscreen
Comment 9•2 years ago
|
||
jackyzy823, thanks for the fix!
It's too late to uplift this fix to a Firefox 116.x dot release, but we should consider uplifting to Beta 117.
Comment 10•2 years ago
|
||
The patch landed in nightly and beta is affected.
:jackyzy823, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox117
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Comment 12•2 years ago
|
||
Comment on attachment 9348971 [details] [review]
[mozilla-mobile/firefox-android] Bug 1836896 - Hide statusbar when fullscreen on Android R+ devices (backport #2844) (#3274)
Beta/Release Uplift Approval Request
- User impact if declined: Full screen videos will display a bar to the left on some devices.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Follow steps in bug
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
- Is Android affected?: No
Comment 13•2 years ago
|
||
Comment 14•2 years ago
|
||
Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/dbd55af37172174fd48aac5177dbf82b3b502514
[releases_v117] Bug 1836896 - Hide statusbar when fullscreen
Comment 15•2 years ago
|
||
Verified as fixed on the latest Beta 117.0b8, and on the latest Nightly (118.0a1 from 2023-08-16).
The purple bar is not visible.
Checked on both normal and private mode.
Verified the video from the description and the one mentioned in comment 3.
Devices used:
- Google Pixel 7 (Android 14).
- Google Pixel 6 (Android 14).
- Oppo Find X5 (Android 13).
- Oppo Find X3 Lite (Android 11).
- Motorola Moto G9 plus (Android 11).
- Samsung Galaxy Note 8 (Android 9).
- Samsung Galaxy S9 (Android 8).
Marking the ticket as verified for 117 and 118.
Updated•2 years ago
|
Description
•