1836928 - Change some references to raw pointers in some FFI functions.

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1836928 - Change some references to raw pointers in some FFI functions. r=glandium

Even tho https://github.com/rust-lang/rust/issues/112337 is IMO a rust
bug, it's easy to work around in our code and it doesn't really affect
expressiveness.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ba8c894161d
Change some references to raw pointers in some FFI functions. r=glandium

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5ba8c894161d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Does this need backporting like the other Rust 1.70 fixes?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9337630 [details]
Bug 1836928 - Change some references to raw pointers in some FFI functions. r=glandium

Beta/Release Uplift Approval Request

• User impact if declined: Rust 1.70 could misoptimize some code.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial tweak.
• String changes made/needed: none
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9337630 [details]
Bug 1836928 - Change some references to raw pointers in some FFI functions. r=glandium

Approved for 115.0b3.

Comment 7

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/114b50782a4d

Comment 8

[Mike Hommey [:glandium]]

We should get that on esr too. As well as release if 114.0.1 is on the table.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9337630 [details]
Bug 1836928 - Change some references to raw pointers in some FFI functions. r=glandium

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: prevents issues with newer llvm versions.
• User impact if declined:
• Fix Landed on Version: 115
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial change to FFI function definition.

Comment 10

[Donal Meehan [:dmeehan]]

:emilio this has merge conflicts with esr102 caused by Bug 1832173

Comment 11

[Pascal Chevrel:pascalc]

It also has merge conflict for mozilla-release, emilio do we need to uplift with bug 1836723 & bug 1836883 or can I uplift them without this bug. Thanks.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9337630 [details]
Bug 1836928 - Change some references to raw pointers in some FFI functions. r=glandium

Yeah, actually I guess this is not really worth uplifting with all those other changes, it's quite a big patch set...