1836933 - Please create "tabbrowser-reviewers" group and a matching Herald rule

Status: RESOLVED FIXED

(Conduit :: Phabricator, task)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1836932 +++

For changes to code in the Tabbed Browser submodule, please create a tabbrowser-reviewers group containing:

• Dão Gottwald, https://phabricator.services.mozilla.com/p/dao/
• Marco Bonardo, https://phabricator.services.mozilla.com/p/mak/

Please also create a Herald rule to add the group as a blocking reviewer for the following files:

• browser/base/content/tabbrowser*
• browser/modules/AsyncTabSwitcher.jsm

Thank you!

Comment 1

[David Lawrence [:dkl]]

Done
https://phabricator.services.mozilla.com/project/profile/180/
https://phabricator.services.mozilla.com/H393

Comment 2

[Dão Gottwald [:dao]]

Hey, the regexp should be @/?browser/(base/content/tabbrowser|modules/AsyncTabSwitcher.jsm$)@, i.e. no slash after tabbrowser as there's no such folder, only a bunch of files... Thanks :)

Comment 3

[David Lawrence [:dkl]]

Ah thanks for pointing that out. Fixed now.