1837032 - Reflect hazard analysis annotations in the callgraph

Status: ASSIGNED

(Core :: JavaScript: GC, enhancement, P2)

Description

[Steve Fink [:sfink] [:s:]]

When looking at hazards, it is very common to want to query the callgraph to see what other paths through the callgraph could lead to a GC. It will almost always several that would not be reported as causing hazards in practice, because they are annotated away in annotations.js. (In-source annotations are mostly already present in the callgraph.) So the first thing I have to do is manually ignore a bunch of different functions.

Although it is less efficient, it is more convenient for the annotations to be recorded in the callgraph. Any function that is annotated as not GC'ing will be treated as if it were in a GC-suppression region. The pathfinding code (in both the analysis and separate tool) will automatically take this into account (call edges have attributes such as "ATTR_GC_SUPPRESSED".)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1837032 - Move the annotation for direct function calls that cannot GC up earlier so it will be incorporated in the callgraph. This will slow things down slightly, but will make the callgraph more useful for manual exploration.