Closed Bug 1837036 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 40398 - Don't call ChildrenChangedWithCleanLayout on a detached object.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox116 fixed)

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 40398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/40398
Details from upstream follow.

Chris Harrelson <chrishtr@chromium.org> wrote:

Don't call ChildrenChangedWithCleanLayout on a detached object.

Fixes the referenced crash bug; attached test crashes without this CL.
ChildrenChangedWithCleanLayout already has a DCHECK that it's not
called with a detached object.

Bug: 1450792

Change-Id: If44d0eaab895b4ae576a6d0bc3ba5180d56576a4

Reviewed-on: https://chromium-review.googlesource.com/4595459
WPT-Export-Revision: 44e630bf04045599d1476409e07ed7356269b011

Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47cf4f530431 [wpt PR 40398] - Don't call ChildrenChangedWithCleanLayout on a detached object., a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/47cf4f530431

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.