1837037 - Implement a pref to enable the new Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task)

Description

[Mike Kaply [:mkaply]]

For experiments, we need a pref to flip on firefox View.

Easiest way to do that is

Add about:firefoxview-next to this list:

https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/browser/base/content/browser.js#689

And then use a pref to change the about:firefoxview here

https://searchfox.org/mozilla-central/rev/aec3a901e6f6b3041b5ec457c9111a042cef1fb1/browser/base/content/browser.js#9834

to about:firefoxview-next

We'll also need to report telemetry that we're using the new view so we can properly check the probes and associate them with either view.

Comment 1

[Mike Kaply [:mkaply]]

Information about running the experiment is here:

https://experimenter.info/desktop-pref-experiments

Comment 2

[Sarah Clements [:sclements]]

Open question that we need to confirm is whether the existing "about:firefoxview" tab will have the same discoverability/styling changes applied (which are WIP) as the "about:firefoxview-next" tab that we'll add as a condition for the pref/experiment.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1837037 - Add a pref for enabling the new Firefox View. r?kcochrane

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7af0a23c7213
Add a pref for enabling the new Firefox View. r=kcochrane,fxview-reviewers

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for causing multiple failures due to browser.xhtml

• backout: https://hg.mozilla.org/integration/autoland/rev/600cc012d6b9188675e40090c40491541a38c598
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=7af0a23c7213ac308f4a02c19d6891855aec02c1&selectedTaskRun=KRvFIVQuRKSoGNxGARBVJg.0
• failure log: https://treeherder.mozilla.org/logviewer?job_id=420862515&repo=autoland&lineNumber=4535

[task 2023-06-28T00:12:53.194Z] 00:12:53     INFO - TEST-INFO | Main app process: exit 0
[task 2023-06-28T00:12:53.196Z] 00:12:53     INFO - TEST-INFO | Confirming we saw 170 DOCSHELL created and 170 destroyed log strings.
[task 2023-06-28T00:12:53.198Z] 00:12:53     INFO - TEST-INFO | Confirming we saw 436 DOMWINDOW created and 436 destroyed log strings.
[task 2023-06-28T00:12:53.200Z] 00:12:53    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_linkopen.js | leaked 8 window(s) until shutdown [url = about:blank]
[task 2023-06-28T00:12:53.201Z] 00:12:53    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_linkopen.js | leaked 8 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]
[task 2023-06-28T00:12:53.203Z] 00:12:53     INFO - TEST-INFO | browser/base/content/test/contextMenu/browser_contextmenu_linkopen.js | windows(s) leaked: [pid = 1576] [serial = 42], [pid = 1576] [serial = 22], [pid = 1576] [serial = 25], [pid = 1576] [serial = 45], [pid = 1576] [serial = 46], [pid = 1576] [serial = 41], [pid = 1576] [serial = 49], [pid = 1576] [serial = 34], [pid = 1576] [serial = 37], [pid = 1576] [serial = 50], [pid = 1576] [serial = 38], [pid = 1576] [serial = 33], [pid = 1576] [serial = 29], [pid = 1576] [serial = 21], [pid = 1576] [serial = 30], [pid = 1576] [serial = 26]
[task 2023-06-28T00:12:53.204Z] 00:12:53     INFO - TEST-INFO | browser/base/content/test/contextMenu/browser_contextmenu_linkopen.js | This test created 1 hidden window(s)
[task 2023-06-28T00:12:53.206Z] 00:12:53     INFO - TEST-INFO | browser/base/content/test/contextMenu/browser_contextmenu_linkopen.js | This test created 1 hidden docshell(s)
[task 2023-06-28T00:12:53.207Z] 00:12:53    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_view_image.js | leaked 3 window(s) until shutdown [url = about:blank]
[task 2023-06-28T00:12:53.209Z] 00:12:53    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_view_image.js | leaked 3 window(s) until shutdown [url = chrome://browser/content/browser.xhtml]

Comment 6

[Natalia Csoregi [:nataliaCs]]

Also failing: TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_windowStateContainer.js | Test timed out -

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6bf06b35009
Add a pref for enabling the new Firefox View. r=kcochrane,fxview-reviewers

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d6bf06b35009

Comment 9

[Mike Kaply [:mkaply]]

This landed.