1837140 - (egl-linux-vaapi-release-amd) Enable VA-API for release on AMD

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Enable VA-API for release on AMD.

We should enable it for Mesa >= 23.1.1 due to (https://gitlab.freedesktop.org/mesa/mesa/-/issues/8996

Comment 1

[Mario Limonciello]

I've run through and triaged all the Depends on bugs for this issue. I feel that they are all sufficiently fixed by kernel driver changes or GPU firmware. Can we re-evaluate enabling by default now?

Comment 2

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mario Limonciello from comment #1)

I've run through and triaged all the Depends on bugs for this issue. I feel that they are all sufficiently fixed by kernel driver changes or GPU firmware. Can we re-evaluate enabling by default now?

Mario, which Mesa version we should consider for it?
Thanks.

Comment 3

[Mario Limonciello]

IMO the mesa version you have is correct. At least from the bugs I've triaged the problem is mainly along the kernel version or VCN microcode version. I don't think Firefox should be in the business of tracking the VCN microcode version for reach product. It's better to advocate that it be pushed down to stable distros that "also" track a newer Firefox version.

One idea that comes to mind for me though is that Firefox could only enable VA-API by default on kernel 6.7 or newer. This will guarantee that any of the SDMA 5.2 systems (Such as Rembrandt and Van Gogh) have picked up the SDMA fix. It will mean that unaffected products that could safely enable it don't, but it's a 'line in the sand'. "Effectively" newer distros could enable VA-API by default.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mario Limonciello from comment #3)

One idea that comes to mind for me though is that Firefox could only enable VA-API by default on kernel 6.7 or newer. This will guarantee that any of the SDMA 5.2 systems (Such as Rembrandt and Van Gogh) have picked up the SDMA fix. It will mean that unaffected products that could safely enable it don't, but it's a 'line in the sand'. "Effectively" newer distros could enable VA-API by default.

Bug 1892845 reports broken AV1 seek on Linux 6.8.10-300.fc40.x86_64 / AMD Radeon Graphics (radeonsi, rembrandt, LLVM 18.1.1, DRM 3.57, 6.8.10-300.fc40.x86_64).

Comment 5

[Martin Stránský [:stransky] (ni? me)]

We may consider to enable VA-API on AMD too. Haven't seen any reports recently and Fedora has it enabled by default already.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

(In reply to Mario Limonciello from comment #3)

One idea that comes to mind for me though is that Firefox could only enable VA-API by default on kernel 6.7 or newer. This will guarantee that any of the SDMA 5.2 systems (Such as Rembrandt and Van Gogh) have picked up the SDMA fix. It will mean that unaffected products that could safely enable it don't, but it's a 'line in the sand'. "Effectively" newer distros could enable VA-API by default.

Mario, any suggestion which MESA version should be considered to enable VA-API on AMD?
Thanks.

Comment 7

[Mario Limonciello]

I checked with mesa folks and they suggest to set the baseline as mesa 24.3.

Comment 8

[Mario Limonciello]

Actually, on a second look, 24.2 is OK [1].

If you choose to also detect kernel version, there is an important fix for Navi21 that was included in kernel 6.10 [2]. This commit has also been backported to many stable kernels though and major distros track those (6.8.9, 6.6.30, 6.1.90, 5.15.158, 5.10.216) so I could see an argument for avoiding doing a kernel version check.

[1] The reason is there was a commit backported to 24.2.0 from 24.3 release that's important (https://gitlab.freedesktop.org/mesa/mesa/-/commit/0c024bbe641b092bbb).

[2] https://github.com/torvalds/linux/commit/e0a9bbeea00234c468607b369816547ca8c86458

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1837140 [Linux] Enable video hardware decoding on AMD by default on MESA >= 24.2 r?aosmond

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Enables hardware video decoding on AMD graphics cards.
[Affects Firefox for Android]: no
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/353a8cb34e3b
[Linux] Enable video hardware decoding on AMD by default on MESA >= 24.2 r=aosmond

Comment 12

[amarc]

https://hg.mozilla.org/mozilla-central/rev/353a8cb34e3b

Comment 13

[Donal Meehan [:dmeehan]]

Added to the Fx136 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx136 release notes.