1837146 - Implement a platform font-list backend for iOS

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement)

Description

[Jonathan Kew [:jfkthame]]

(I think this will basically be an updated/rewritten version of what bug 1170986 was investigating.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1837146 - patch 1 - Refactor gfxMacPlatformFontList to separate out an abstract, Cocoa-independent CoreTextFontList class, and a small Cocoa-specific gfxMacPlatformFontList implementation.

This should not change user-visible behavior, in principle (though it's possible there will be
minor changes due to using more Core Text APIs in place of Cocoa to enumerate available fonts,
and they may interpret font attributes slightly differently).

AFAICS current macOS tests continue to pass with this refactoring.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1837146 - Create an IOSPlatformFontList concrete implementation of CoreTextFontList.

This builds and should come close to working, I hope, but is currently untested.

Depends on D180191

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1837146 - patch 0 - Reformat gfxMacPlatformFontList.mm with clang-format as though it were a .cpp file.

No functional change. The issue here is that we're going to move a lot of the contents of this file
to a new .cpp source file; but we have different line-length specifications for .mm vs .cpp files,
and so that results in clang-format making a lot of whitespace-only changes to adjust the lines.

To try and simplify review, this preparatory patch is created by running clang-format on the file
as if it were a .cpp source, so that the whitespace adjustments get done. Then the following patch,
which moves much of the content to CoreTextFontList.cpp, will already see the whitespace in the form
it expects.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1837146 - patch 1.1 - Reformat the remains of gfxMacPlatformFontList.mm back to Obj-C++ style.

No functional change; just applying clang-format to what remains in the Obj-C++ file here,
after factoring out the common Core Text part to a separate .cpp source file.

Depends on D180191

Comment 5

[Jonathan Kew [:jfkthame]]

Landed on cedar:
remote: https://hg.mozilla.org/projects/cedar/rev/105bd71e06bf921032d423468e5655fceb51f3f7
remote: https://hg.mozilla.org/projects/cedar/rev/ec4f8bcf0d598fb6ddab2e3c0b0e11f49376312f
remote: https://hg.mozilla.org/projects/cedar/rev/d8025bccaa6d3d6486413c7d6a257b7344845342
remote: https://hg.mozilla.org/projects/cedar/rev/61e53356420cacfa6b5fdb045c0c5074827f7137

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jfkthame, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 7

[Jonathan Kew [:jfkthame]]

These patches have landed on Cedar for now.

Comment 8

[Phabricator Automation]

Comment on attachment 9338051 [details]
Bug 1837146 - patch 0 - Reformat gfxMacPlatformFontList.mm with clang-format as though it were a .cpp file.

Revision D180324 was moved to bug 1170986. Setting attachment 9338051 [details] to obsolete.

Comment 9

[Phabricator Automation]

Comment on attachment 9337837 [details]
Bug 1837146 - patch 1 - Refactor gfxMacPlatformFontList to separate out an abstract, Cocoa-independent CoreTextFontList class, and a small Cocoa-specific gfxMacPlatformFontList implementation.

Revision D180191 was moved to bug 1170986. Setting attachment 9337837 [details] to obsolete.

Comment 10

[Phabricator Automation]

Comment on attachment 9338052 [details]
Bug 1837146 - patch 1.1 - Reformat the remains of gfxMacPlatformFontList.mm back to Obj-C++ style.

Revision D180325 was moved to bug 1170986. Setting attachment 9338052 [details] to obsolete.

Comment 11

[Mike Hommey [:glandium]]

We're moving forward with landing stuff on m-c. I updated the patch to be in a landable state. Do you mind if I land it? (or you can land it too, that would work)

Comment 12

[Jonathan Kew [:jfkthame]]

(In reply to Mike Hommey [:glandium] from comment #11)

We're moving forward with landing stuff on m-c. I updated the patch to be in a landable state. Do you mind if I land it? (or you can land it too, that would work)

Feel free to go ahead. Thanks for updating it as needed.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27383348695c
Create an IOSPlatformFontList concrete implementation of CoreTextFontList. r=gfx-reviewers,lsalzman

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/27383348695c