1837153 - Make RFPTarget parameter in various ShouldResistFingerprinting methods non-optional (continued)

Status: RESOLVED FIXED

(Core :: Security, task)

Description

[Tom S [:evilpie]]

+++ This bug was initially created as a clone of Bug #1834737 +++

By making this parameter non-optional we enforce the passing of a specific RFPTarget value, in rare cases we could also pass RFPTarget::Unknown explicitly.

Comment 1

[Tom Schuster]

Attachment: Bug 1837153 - Remove more RFPTarget::Unknown default parameters in classes inheriting from nsIGlobalObject. r?tjr

Depends on D179535

Comment 2

[Tom Schuster]

Attachment: Bug 1837153 - Make RFPTarget parameter of ShouldResistFingerprinting with nsIChannel non-optional. r?tjr

Comment 3

[Tom Schuster]

Attachment: Bug 1837153 - Make RFPTarget parameter of ShouldResistFingerprinting with nsILoadInfo non-optional. r?tjr

Depends on D180430

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b447d95efe6e
Remove more RFPTarget::Unknown default parameters in classes inheriting from nsIGlobalObject. r=tjr
https://hg.mozilla.org/integration/autoland/rev/7c5fa154397d
Make RFPTarget parameter of ShouldResistFingerprinting with nsIChannel non-optional. r=tjr,cookie-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/e17bfa5f8959
Make RFPTarget parameter of ShouldResistFingerprinting with nsILoadInfo non-optional. r=tjr

Comment 5

[Tom Schuster]

Attachment: Bug 1837153 - Make RFPTarget parameter of bare ShouldResistFingerprinting non-optional. r?tjr

Comment 6

[Tom Schuster]

Attachment: Bug 1837153 - Make RFPTarget parameter of ShouldResistFingerprinting with justification non-optional. r?tjr

Depends on D180666

Comment 7

[Tom Schuster]

Attachment: Bug 1837153 - Make RFPTarget parameter of ShouldResistFingerprinting_dangerous non-optional. r?tjr

Depends on D180667

Comment 8

[Cristian Tuns]

Backed out for causing build bustages in nsGlobalWindowInner.cpp on Android

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/base/nsGlobalWindowInner.cpp:6560:35: error: too few arguments to function call, single argument 'aTarget' was not specified

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c5c7dcce429
Remove more RFPTarget::Unknown default parameters in classes inheriting from nsIGlobalObject. r=tjr
https://hg.mozilla.org/integration/autoland/rev/01ee0e05b56c
Make RFPTarget parameter of ShouldResistFingerprinting with nsIChannel non-optional. r=tjr,cookie-reviewers,timhuang,geckoview-reviewers,owlish

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3c5c7dcce429
https://hg.mozilla.org/mozilla-central/rev/01ee0e05b56c

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81e6a5b31562
Make RFPTarget parameter of ShouldResistFingerprinting with nsILoadInfo non-optional. r=tjr
https://hg.mozilla.org/integration/autoland/rev/95d02758e6a5
Make RFPTarget parameter of bare ShouldResistFingerprinting non-optional. r=tjr,necko-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/248dc47c122c
Make RFPTarget parameter of ShouldResistFingerprinting with justification non-optional. r=tjr
https://hg.mozilla.org/integration/autoland/rev/c9eaf7497902
Make RFPTarget parameter of ShouldResistFingerprinting_dangerous non-optional. r=tjr,cookie-reviewers,timhuang
https://hg.mozilla.org/integration/autoland/rev/f62e9abb68f8
apply code formatting via Lando

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/81e6a5b31562
https://hg.mozilla.org/mozilla-central/rev/95d02758e6a5
https://hg.mozilla.org/mozilla-central/rev/248dc47c122c
https://hg.mozilla.org/mozilla-central/rev/c9eaf7497902
https://hg.mozilla.org/mozilla-central/rev/f62e9abb68f8