183722 - missing hotsync log entry on both PC and Palm to indicate Mozilla Address Book Sync

Status: RESOLVED FIXED

(MailNews Core Graveyard :: Palm Sync, defect)

Description

[Stew Feuerstein]

User-Agent:       Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2.1) Gecko/20021130

I finally got Address Sync to work, after updating the registry.  I am using
Palm Hotsync 4.1 .  After hot synching if you click on 'view log' either on the
palm or in the Hotsync PC software, there is no indication that a Mozilla
Address Book hotsync occured.  Other conduits put a message in both like
Avantgo's 'OK Mobile Application Link' or Palm's 'OK Notepad'.

Reproducible: Always

Steps to Reproduce:
1.  Hotsync
2.  Click on 'log' radio button on Palm or right click on Hotsync Icon in PC
system tray and select 'view log'.


Actual Results:  
Only messages from other conduits.

Expected Results:  
added a message to the log similar to:
OK Mozilla Address Book

Comment 1

[Brian Atkins]

I can confirm this as well.  Although the Palm (Handspring Visor in
my case) reports the synchronization on the screen, there is no
report in the log.

Comment 2

[Ninoschka Baca]

Nominating because viewing a HotSync Log and expecting the Mozilla Address Book
to be listed is expected.

Comment 3

[Samir Gehani]

Mail triage team: nsbeta1+/adt3

Comment 4

[Samir Gehani]

-> cavin

Comment 5

[Cavin Song]

Attachment: Draft, not a patch yet.

It creates the following entry in the PC HotSync manager's log (ie, click 'View
Log' to see the log):

   OK MozABConduit

Right now GetConduitName() returns a hard coded name "MozABConduit", so still
need to fix this. Also need to figure out how to add a log entry to the
handheld side.

Comment 6

[Cavin Song]

Attachment: Draft, not a patch yet.

This one creates log entries on the handheld as well. Still need to resolve a
better conduit name.

Comment 7

[Wayne Mery (:wsmwk)]

is the patch still valid?

Comment 8

[post]

Concerning hotsync address base I can confirm the bug - there is no 
confirmation of the hot sync process in the log (f.example "OK mozilla address 
book") - it does not appear in the log.

(Palm 5, W2k SP4/ 5 ...)

Comment 9

[post]

I can confirm this bug ;-( ; about 30 entries are missing, too.

Comment 10

[post]

I can confirm this bug ;-( ; about 30 entries are missing, too.
(Palm 5, W2k SP4/5...)

Comment 11

[Wayne Mery (:wsmwk)]

Example log...

HotSync operation started 10/12/05 07:51:28
OK Install
OK Date Book
OK To Do List
OK Memo Pad
OK Expense
[we should see "OK Mozilla Address Book"]
...
OK System
HotSync operation complete 10/12/05 07:54:37

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 123198 [details] [diff] [review]
Draft, not a patch yet.

David, looks good except need better conduit name for the log as noted in
comments 6 & 7. what do you think?  Note patch is is for the hotsync log, not
the optional PC conduit log.

Comment 13

[David :Bienvenu]

Comment on attachment 123198 [details] [diff] [review]
Draft, not a patch yet.

I'll try this out. Thx for the patch.

Comment 14

[Wayne Mery (:wsmwk)]

(In reply to comment #13)
> (From update of attachment 123198 [details] [diff] [review] [edit])
> I'll try this out. Thx for the patch.

David, can we land the patch and get it tested?
Then do a second patch to improve the name (eg "Mozilla Address Book").

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to comment #13)
> (From update of attachment 123198 [details] [diff] [review])
> I'll try this out. Thx for the patch.

David, can you hook me up with an extension built against TB 2.0 with this patch?

Comment 16

[David :Bienvenu]

I don't think I'm set up to build the extension anymore - I don't have the latest palm SDK (though I'm not sure that's required or not...)

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 123198 [details] [diff] [review]
Draft, not a patch yet.

obsolete - might have been good 11 versions ago

interesting find - according to palm conduit documentation "Note that HotSync Manager automatically logs the general success or failure status of your conduit; therefore you need not add an entry for this purpose."

Don't know if that's true and if so why it's not doing that. Anyway, revised patch coming up.

Comment 18

[Wayne Mery (:wsmwk)]

Attachment: Add HSM log entry v1

Includes flag to HSM that conduit is finished syncing.

Comment 19

[Wayne Mery (:wsmwk)]

David, is the build system still using CDK 4.03? Or is it the newer 6.01?

Comment 20

[David :Bienvenu]

4.03 - I couldn't get the conduit to compile with 6.01, at least on the 2.0 branch.

Comment 21

[Wayne Mery (:wsmwk)]

Attachment: Add HSM log entry v2

David here's v2 for respin of extension

Comment 22

[Wayne Mery (:wsmwk)]

Attachment: Add HSM log entry v3 (contains bad file name)

logs to HSM (and conduit log) at beginning and end of sync.

for slSyncFinished I removed "without errors" from the message because I'm not convinced yet that retval=0 can be completely trusted to indicate the sync finished without error.

David, please e-mail me the resulting XPI. Thanks.

Comment 23

[Wayne Mery (:wsmwk)]

Attachment: Add HSM log entry v3

fix file name in patch

Comment 24

[Wayne Mery (:wsmwk)]

Attachment: Add HSM log entry v4

move start and end log entries to more completely bracket the code. add new line on starting entry. That should do it.

Comment 25

[Wayne Mery (:wsmwk)]

David, please commit patch v4 to trunk and branch. Thanks

Comment 26

[Wayne Mery (:wsmwk)]

Comment on attachment 261210 [details] [diff] [review]
Add HSM log entry v4

desired on branch to improve debugging of palmsync conduit starting with TB 2.

Comment 27

[Daniel Veditz [:dveditz]]

Comment on attachment 261210 [details] [diff] [review]
Add HSM log entry v4

Please get reviews before requesting branch approval.

Comment 28

[Wayne Mery (:wsmwk)]

attachment 261210 [details] [diff] [review] patch worked without problems for at least three testers. 

Comment 29

[David :Bienvenu]

Comment on attachment 261210 [details] [diff] [review]
Add HSM log entry v4

fix checked into the trunk and 2.0 branch, thx, Wayne!

Comment 30

[David :Bienvenu]

marking fixed, and adding keyword (even though it's not really part of the build)

Comment 31

[Wayne Mery (:wsmwk)]

wanted on branch to issue updated palmsync extension conduit for TB 2.  Only affects conduit modules. Does not touch thunderbird or core modules.

Comment 32

[David :Bienvenu]

clearing blocking request - I already landed this on the branch, since it's not part of the build.